all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add qscintilla.
Date: Tue, 13 Sep 2016 13:05:29 -0400	[thread overview]
Message-ID: <20160913170529.GD20731@jasmine> (raw)
In-Reply-To: <87r38ndfwb.fsf@openmailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote:
> Kei Kebreau <kei@openmailbox.org> writes:
> > A component necessary for GNU Octave's GUI.
> > How does it look?
> Not sure how packaging Qt packages goes, but I've discovered that
> GNU Octave's GUI only builds with Qt4 support. I've changed the patch to
> adjust this. Should I leave the old patch as is and add a qt4 package
> that inherits from it?

Since Qt 4 is no longer supported upstream, we are trying to remove
users of the qt-4 package so that we can eventually remove the qt-4
package itself.

With that in mind, how about a qscintilla-for-octave package? This
package can inherit from a qscintilla that uses qtbase, and I think it
should be declared privately [using (define) instead of (define-public].

> +         (replace 'configure
> +           (lambda _
> +             (chdir "Qt4Qt5")
> +             (zero? (system* "qmake" "qscintilla.pro"))))

I would change directory in a separate 'chdir' phase.

> +               (substitute* (find-files "." "Makefile")
> +                 (((string-append "INSTALL_ROOT)" qt))
> +                  (string-append "INSTALL_ROOT)" out)))))))))
                     ^
Inconsistent indentation. Also, this phase should return #t, since the
return value of substitute* is unspecified.

> +    (synopsis "Qt5 port of the Scintilla editing component")

Make sure to adjust the Qt name as appropriate :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-09-13 17:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 17:31 [PATCH] gnu: Add qscintilla Kei Kebreau
2016-09-13 14:37 ` Kei Kebreau
2016-09-13 17:05   ` Leo Famulari [this message]
2016-09-13 18:01     ` Kei Kebreau
2016-09-13 18:14       ` Leo Famulari
2016-09-13 18:59         ` Kei Kebreau
2016-09-13 19:04           ` Leo Famulari
2016-09-13 19:40             ` Kei Kebreau
2016-09-13 19:39       ` Efraim Flashner
2016-09-13 20:37         ` Kei Kebreau
2016-09-13 20:48           ` Efraim Flashner
2016-09-14 17:08             ` Leo Famulari
2016-09-14 18:11               ` Kei Kebreau
2016-09-14 18:56                 ` Leo Famulari
2016-09-14 20:37                   ` Kei Kebreau
2016-09-14 20:42                     ` Efraim Flashner
2016-09-15 14:20                       ` Kei Kebreau
2016-09-15 14:25                         ` Kei Kebreau
2016-09-18  8:36           ` Andreas Enge
2016-09-18 20:10             ` Kei Kebreau
2016-09-18 20:56               ` Leo Famulari
2016-09-18 21:02                 ` Efraim Flashner
2016-09-19 13:18                   ` Kei Kebreau
2016-09-19 13:25                     ` Ricardo Wurmus
2016-09-19 14:47                       ` Kei Kebreau
2016-09-19 21:32                         ` Leo Famulari
2016-09-19 21:45                           ` Kei Kebreau
2016-09-19 23:52                             ` Leo Famulari
2016-09-22 19:02                               ` Ricardo Wurmus
2016-09-24  3:30                                 ` Leo Famulari
2016-09-24  5:13                                   ` Kei Kebreau
2016-09-25 17:05                                     ` Leo Famulari
2016-09-25 19:25                                       ` Kei Kebreau
2016-10-03 16:17                             ` Ludovic Courtès
2016-09-19 13:30                     ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160913170529.GD20731@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.