From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add darkhttpd.
Date: Tue, 13 Sep 2016 11:42:43 -0400
Message-ID: <20160913154243.GB13516@jasmine>
References: <87bmzv3b04.fsf@gmail.com>
	<20160911192014.23019-1-arunisaac@systemreboot.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjprR-0005Zr-RY
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjprN-0007pl-Rq
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:43:01 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40497)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjprL-0007TI-J3
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:42:57 -0400
Content-Disposition: inline
In-Reply-To: <20160911192014.23019-1-arunisaac@systemreboot.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: guix-devel@gnu.org

On Mon, Sep 12, 2016 at 12:50:14AM +0530, Arun Isaac wrote:
> * gnu/packages/web.scm (darkhttpd): New variable.

Thanks for this patch!

> +    (version "1.12")
> +    (source
> +     (origin
> +       ;; The darkhttpd release tarball URL fails to download with a
> +       ;; 'TLS warning alert'. Download from the darkhttpd git repo
> +       ;; until the problem has been fixed upstream.
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url (string-append "https://unix4lyfe.org/git/darkhttpd"))
> +             (commit "master")))

If I understand correctly, this will not work as expected. When the
master branch gets another commit, our package's hash will become
invalid.

Too bad upstream doesn't make Git tags for their releases. Commit
41b68476c35270f47dcd2ddebe27cbcd87e43d41 appears to correspond to the
1.12 release, so we should specify that commit:

https://unix4lyfe.org/gitweb/darkhttpd/commit/41b68476c35270f47dcd2ddebe27cbcd87e43d41

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "darkhttpd"
> +                           (string-append (assoc-ref outputs "out")
> +                                          "/bin"))
> +             #t)))))

Did you notice if there is any documentation that could be installed too?

In any case, can you send a revised patch addressing the commit /
version issue?