[PATCH] gnu: Add microcom

[PATCH] gnu: Add microcom

[John Darrington]

* gnu/packages/microcom.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk              |  1 +
 gnu/packages/microcom.scm | 57 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 gnu/packages/microcom.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 8b042d5..b274fca 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -239,6 +239,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/mcrypt.scm			\
   %D%/packages/messaging.scm			\
   %D%/packages/mg.scm				\
+  %D%/packages/microcom.scm			\
   %D%/packages/mit-krb5.scm			\
   %D%/packages/moe.scm				\
   %D%/packages/mono.scm				\
diff --git a/gnu/packages/microcom.scm b/gnu/packages/microcom.scm
new file mode 100644
index 0000000..1bb68c4
--- /dev/null
+++ b/gnu/packages/microcom.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John Darrington <jmd@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages microcom)
+  #:use-module (guix packages)
+  #:use-module (guix licenses)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages readline)
+  #:use-module (guix build-system gnu))
+
+(define-public microcom
+  (package
+    (name "microcom")
+    (version "2016.01.09")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "git://git.pengutronix.de/git/tools/microcom.git")
+                    (commit "caf3687611ca855b4fa80c2a9a2fbb020834fc4e")))
+              (file-name (string-append name "-" version "-checkout"))
+              (sha256
+               (base32
+                "080ci5589bpyy5kcl51csmvpw9zysify189hw6awx69pi3cjnxly"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'bootstrap
+           (lambda _
+             (zero? (system* "autoreconf" "-i")))))))
+    (inputs `(("readline" ,readline)))
+    (native-inputs `(("automake" ,automake)
+                     ("autoconf" ,autoconf)))
+    (home-page  "http://git.pengutronix.de/?p=tools/microcom.git")
+    (synopsis "Minimalistic serial line terminal program")
+ (description "Microcom is a minimalistic terminal program for accessing
+devices via a serial connection.  It features connection via RS232 serial
+interfaces (including setting of transferrates) as well as in `telnetmode'
+as specified in rfc2217 and a (Linux specific) CAN mode.")
+    (license gpl2+)))
-- 
2.1.4

Re: [PATCH] gnu: Add microcom

[Leo Famulari]

On Sun, Sep 11, 2016 at 06:56:58PM +0200, John Darrington wrote:
> * gnu/packages/microcom.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

> +    (version "2016.01.09")

I think we should use the upstream tag, "v2016.01.0".

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "git://git.pengutronix.de/git/tools/microcom.git")
> +                    (commit "caf3687611ca855b4fa80c2a9a2fbb020834fc4e")))

Then, you can use the tag name as the commit. The tag I mentioned is
equivalent to this commit.

> +    (license gpl2+)))

My interpretation of the first paragraph of COPYING [0] is that the
package is licensed under the GPL version 2 only. What do you think?

[0]
http://git.pengutronix.de/?p=tools/microcom.git;a=blob;f=COPYING

Re: [PATCH] gnu: Add microcom

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Tue, Sep 13, 2016 at 11:36:17AM -0400, Leo Famulari wrote:
     On Sun, Sep 11, 2016 at 06:56:58PM +0200, John Darrington wrote:
     > * gnu/packages/microcom.scm: New file.
     > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
     
     > +    (version "2016.01.09")
     
     I think we should use the upstream tag, "v2016.01.0".
     
     > +    (source (origin
     > +              (method git-fetch)
     > +              (uri (git-reference
     > +                    (url "git://git.pengutronix.de/git/tools/microcom.git")
     > +                    (commit "caf3687611ca855b4fa80c2a9a2fbb020834fc4e")))
     
     Then, you can use the tag name as the commit. The tag I mentioned is
     equivalent to this commit.

I will do that.  Thanks.
     
     > +    (license gpl2+)))
     
     My interpretation of the first paragraph of COPYING [0] is that the
     package is licensed under the GPL version 2 only. What do you think?

All the .c files in the package explicitly say "either version 2 of the License,
 or (at your option) any later version".
     

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH] gnu: Add microcom

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

On Tue, Sep 13, 2016 at 07:37:49PM +0200, John Darrington wrote:
> On Tue, Sep 13, 2016 at 11:36:17AM -0400, Leo Famulari wrote:
>      On Sun, Sep 11, 2016 at 06:56:58PM +0200, John Darrington wrote:
>      > +    (license gpl2+)))
>      
>      My interpretation of the first paragraph of COPYING [0] is that the
>      package is licensed under the GPL version 2 only. What do you think?
> 
> All the .c files in the package explicitly say "either version 2 of the License,
>  or (at your option) any later version".

Okay, I guess the statement in COPYING [0] can be interpreted to not
exclude distribution under later versions. It merely confirms that you
can distribute under version 2.

[0]
All files included in microcom are distributable under the "GNU GENERAL
PUBLIC LICENSE version 2". (Some might have the "or any later version"
phrase; this doesn't affect the previous statement though.) If the file
doesn't specify a license explicitly, assume "version 2 only". The "GNU
GENERAL PUBLIC LICENSE version 2" is appended below.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]