From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 2/3] gnu: Add wcslib Date: Tue, 13 Sep 2016 14:44:43 +0200 Message-ID: <20160913124443.GA23678@jocasta.intra> References: <1472584872-19300-1-git-send-email-jmd@gnu.org> <1472584872-19300-2-git-send-email-jmd@gnu.org> <874m61fngt.fsf@gmail.com> <8737l58c6r.fsf@gmail.com> <20160912154006.GA6648@jocasta.intra> <87fup4b4oe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjn51-0004li-5z for guix-devel@gnu.org; Tue, 13 Sep 2016 08:44:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjn4x-0004Hq-U5 for guix-devel@gnu.org; Tue, 13 Sep 2016 08:44:51 -0400 Received: from de.cellform.com ([88.217.224.109]:55722 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjn4x-0004HP-Hu for guix-devel@gnu.org; Tue, 13 Sep 2016 08:44:47 -0400 Content-Disposition: inline In-Reply-To: <87fup4b4oe.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 13, 2016 at 11:10:57AM +0300, Alex Kost wrote: John Darrington (2016-09-12 17:40 +0200) wrote: =20 > On Mon, Sep 12, 2016 at 04:44:44PM +0300, Alex Kost wrote: > > I've noticed that you didn't fix these things (long line and #t= after > substitute*). Could please do it next time :-) > > The same for 'cfitsio' package. > > Done. > > If this is important why doesn't guix build and/or guix lint check f= or it? =20 "guix lint" can't check if a phase should end with #t or not, it's up = to you check if it is needed. The thing is: if a phase fails, it should return false value, and if it succeeds, it should return non-false value. A returned value of 'substitute*' is unspecified, so here you should add #t to the end of the phase. It works without it, but I wou= ld say it happens "by chance" because # is considered to be non-false, but we shouldn't rely on it, so adding #t to such phases is the right thing. 1. Presumably guix build somewhere calls something like: (if (run-phase x) (run-next-phase) (error)) We could change this to: (if (let ((result (run-phase x))) (if (unspecfied? result) (error "Result of phase is unspecified")) result) (run-next-phase) (error)) =2E... or something similar ... 2. It wouldn't be a bad idea to change subsitute* to return something. For example, the number of substitutions performed. =20 As for the long line, it is 89 chars long, while "guix lint" reports about exceeding 90 chars (see 'report-long-line' in (guix scripts lint) module). BTW I think this is too loose, I would limit it to 80. =20 But your line could be easily shorten, as I wrote at , so instead of the current long line: =20 (uri (string-append "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" v= ersion ".tar.bz2")) =20 it could be: =20 (uri (string-append "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2")) =20 which fits any screen and thus is more readable I think. =20 I think all the lines are less than 80 right now aren't they? I just felt a bit of a letdown that you ignored my comments and didn't send a message why. =20 I didn't mean to shun you. I appreciate the time and effort you took to= =20 review my code. Unfortunately I find the Guix workflow awkward to manage so sometimes I have omitted corrections which ought to have been made. Part of my problem is that currently (due to lack of many services) I cannot send or receive mail from the machine on which I have GuixSD running. Hopefully this will change soon. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfX9LsACgkQimdxnC3oJ7ObsQCfeV2D8VvWMWNlTpYYqf3mlM/u UjwAniJZwHBK9lDgzXX8eIy5cmhnGAx9 =RD9k -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--