From: John Darrington <john@darrington.wattle.id.au>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: Add wcslib
Date: Tue, 13 Sep 2016 14:44:43 +0200 [thread overview]
Message-ID: <20160913124443.GA23678@jocasta.intra> (raw)
In-Reply-To: <87fup4b4oe.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3203 bytes --]
On Tue, Sep 13, 2016 at 11:10:57AM +0300, Alex Kost wrote:
John Darrington (2016-09-12 17:40 +0200) wrote:
> On Mon, Sep 12, 2016 at 04:44:44PM +0300, Alex Kost wrote:
>
> I've noticed that you didn't fix these things (long line and #t after
> substitute*). Could please do it next time :-)
>
> The same for 'cfitsio' package.
>
> Done.
>
> If this is important why doesn't guix build and/or guix lint check for it?
"guix lint" can't check if a phase should end with #t or not, it's up to
you check if it is needed. The thing is: if a phase fails, it should
return false value, and if it succeeds, it should return non-false
value. A returned value of 'substitute*' is unspecified, so here you
should add #t to the end of the phase. It works without it, but I would
say it happens "by chance" because #<unspecified> is considered to be
non-false, but we shouldn't rely on it, so adding #t to such phases is
the right thing.
1. Presumably guix build somewhere calls something like:
(if (run-phase x) (run-next-phase) (error))
We could change this to:
(if (let ((result (run-phase x)))
(if (unspecfied? result) (error "Result of phase is unspecified"))
result)
(run-next-phase)
(error))
.... or something similar ...
2. It wouldn't be a bad idea to change subsitute* to return something. For
example, the number of substitutions performed.
As for the long line, it is 89 chars long, while "guix lint" reports
about exceeding 90 chars (see 'report-long-line' in (guix scripts lint)
module). BTW I think this is too loose, I would limit it to 80.
But your line could be easily shorten, as I wrote at
<http://lists.gnu.org/archive/html/guix-devel/2016-08/msg02070.html>,
so instead of the current long line:
(uri (string-append
"ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2"))
it could be:
(uri (string-append
"ftp://ftp.atnf.csiro.au/pub/software/wcslib/"
name "-" version ".tar.bz2"))
which fits any screen and thus is more readable I think.
I think all the lines are less than 80 right now aren't they?
I just felt a bit of a letdown that you ignored my comments and
didn't send a message why.
I didn't mean to shun you. I appreciate the time and effort you took to
review my code.
Unfortunately I find the Guix workflow awkward to manage so sometimes I
have omitted corrections which ought to have been made. Part of my
problem is that currently (due to lack of many services) I cannot send or
receive mail from the machine on which I have GuixSD running. Hopefully
this will change soon.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-09-13 12:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 19:21 [PATCH 1/3] gnu: Add cfitsio John Darrington
2016-08-30 19:21 ` [PATCH 2/3] gnu: Add wcslib John Darrington
2016-08-30 20:47 ` Leo Famulari
2016-08-31 6:42 ` Alex Kost
2016-09-12 13:44 ` Alex Kost
2016-09-12 15:40 ` John Darrington
2016-09-13 8:10 ` Alex Kost
2016-09-13 12:44 ` John Darrington [this message]
2016-08-30 19:21 ` [PATCH 3/3] gnu: Add gnuastro John Darrington
2016-08-30 20:45 ` Leo Famulari
2016-08-31 6:47 ` Alex Kost
2016-08-30 20:47 ` [PATCH 1/3] gnu: Add cfitsio Leo Famulari
2016-08-31 6:45 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913124443.GA23678@jocasta.intra \
--to=john@darrington.wattle.id.au \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.