From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: par2cmdline. Date: Mon, 12 Sep 2016 20:36:17 -0500 Message-ID: <20160912203617.2f60f8e0@openmailbox.org> References: <09722be1-ef1a-757a-1e4c-aa6ce5724654@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjceF-0000eQ-Fm for guix-devel@gnu.org; Mon, 12 Sep 2016 21:36:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjceB-0008Eb-8w for guix-devel@gnu.org; Mon, 12 Sep 2016 21:36:30 -0400 Received: from smtp25.openmailbox.org ([62.4.1.59]:48632 helo=smtp10.openmailbox.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjceA-0008Dx-V9 for guix-devel@gnu.org; Mon, 12 Sep 2016 21:36:27 -0400 In-Reply-To: <09722be1-ef1a-757a-1e4c-aa6ce5724654@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Brendan Tildesley Cc: guix-devel@gnu.org Hi! Thanks for the patch; a few comments below: On Mon, 12 Sep 2016 19:18:42 +1000 Brendan Tildesley wrote: > From 0bb6fe510ce6a6c1cd0851527909db16b167d703 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Mon, 12 Sep 2016 16:02:27 +1000 > Subject: [PATCH] gnu: Add par2cmdline. > > * gnu/package/disk.scm (par2cmdline): New variable. [...] > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/Parchive/par2cmdline/archive/v" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0ykfb7ar0x0flfdgf6i8xphyv5b93dalbjj2jb6hx7sdjax33n1g")) > + ;; This test merely needs a file to test recovery on, but > + ;; /dev/random is essentially /dev/urandom plus minimum entropy > + ;; locking, making the test hang indefinitely. This change is > + ;; already upstream: remove on upgrade to future 0.6.15. Could you possobily list the upstream commit id for this change? > + (modules '((guix build utils))) > + (snippet > + '(substitute* "tests/test20" (("if=/dev/random") "if=/dev/urandom"))))) > + (native-inputs > + `(("automake" ,automake) > + ("autoconf" ,autoconf))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'aclocal > + (lambda _ (zero? (system* "aclocal")))) > + (add-after 'aclocal 'automake > + (lambda _ (zero? (system* "automake" "--add-missing")))) > + (add-after 'automake 'autoconf > + (lambda _ (zero? (system* "autoconf"))))))) Could these phases be squashed into a single phase that calls "autoreconf"? > + (synopsis "File verification and repair tool") > + (description "Par2cmdline is a tool for generating RAID-like PAR2 recovery > +files a fraction the size their of using Reed-Solomon coding. PAR2 files can ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I think that bit could be left out. Unless fixing a typo could make it understandable. > +be stored along side backup or published files for recovering from bitrot.") > + (home-page "https://github.com/Parchive/par2cmdline") > + (license (list license:gpl2+ ; * We can leave gpl2+ out, since in this case it is covered by gpl3+ > + license:gpl3+ ; config.guess > + license:x11)))); install-sh Could you send an updated patch? Thanks, `~Eric