From: Efraim Flashner <efraim@flashner.co.il>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 03/16] gnu: Add python-promise.
Date: Mon, 12 Sep 2016 08:31:24 +0300 [thread overview]
Message-ID: <20160912053123.GL6073@macbook42.flashner.co.il> (raw)
In-Reply-To: <CAL1_imkZEz0MZ0Mv9ONOLzvdXvEveB_fNw7Z8FTLkkckgqG6iw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Sun, Sep 11, 2016 at 09:41:10PM +0200, David Craven wrote:
> > +(define-public python2-promise
> > + (let ((promise (package-with-python2
> > + (strip-python2-variant python-promise))))
> > + (package (inherit promise)
> > + (arguments (substitute-keyword-arguments (package-arguments promise)
> > + ((#:tests? _) #t)))
>
> I've seen this in a few of your patches. Why do tests fail with python
> but not with python-2?
In this one the tests require python-futures, which is python2 only. I
tried adding python2-futures anyway to the native-inputs but
unsuprisingly it didn't help with the tests. The right fix is to have
upstream change it so that it says (something like)
tests:
require:
"pytest" ,(version < '3' "futures");
but I need to read up more on my python syntax to suggest a patch.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-12 5:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 18:58 [PATCH 00/16] Add onionshare Efraim Flashner
2016-09-11 18:58 ` [PATCH 01/16] gnu: Add python-pika Efraim Flashner
2016-09-11 19:36 ` David Craven
2016-09-11 19:37 ` David Craven
2016-09-12 5:33 ` Efraim Flashner
2016-09-12 11:56 ` The ‘python2-variant’ property Ludovic Courtès
2016-09-11 18:58 ` [PATCH 02/16] gnu: Add python-peewee Efraim Flashner
2016-09-11 18:58 ` [PATCH 03/16] gnu: Add python-promise Efraim Flashner
2016-09-11 19:41 ` David Craven
2016-09-12 5:31 ` Efraim Flashner [this message]
2016-09-11 18:58 ` [PATCH 04/16] gnu: Add python-pytest-mock Efraim Flashner
2016-09-11 19:42 ` David Craven
2016-09-12 5:34 ` Efraim Flashner
2016-09-11 18:58 ` [PATCH 05/16] gnu: Add python-graphql-core Efraim Flashner
2016-09-11 18:58 ` [PATCH 06/16] gnu: Add python-graphql-relay Efraim Flashner
2016-09-11 19:38 ` David Craven
2016-09-11 18:58 ` [PATCH 07/16] gnu: Add python-sqlalchemy-utils Efraim Flashner
2016-09-11 18:58 ` [PATCH 08/16] gnu: Add python-pytest-django Efraim Flashner
2016-09-11 18:58 ` [PATCH 09/16] gnu: Add python-django-filter Efraim Flashner
2016-09-11 18:58 ` [PATCH 10/16] gnu: Add python-graphene Efraim Flashner
2016-09-11 18:58 ` [PATCH 11/16] gnu: Add python-consul Efraim Flashner
2016-09-11 18:58 ` [PATCH 12/16] gnu: Add python-cov-core Efraim Flashner
2016-09-11 18:58 ` [PATCH 13/16] gnu: Add python-nose2 Efraim Flashner
2016-09-11 19:39 ` David Craven
2016-09-11 18:58 ` [PATCH 14/16] gnu: Add python-bcrypt Efraim Flashner
2016-09-11 18:58 ` [PATCH 15/16] gnu: Add python-nautilus Efraim Flashner
2016-09-11 18:58 ` [PATCH 16/16] gnu: Add onionshare Efraim Flashner
2016-09-11 19:00 ` [PATCH 00/16] " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912053123.GL6073@macbook42.flashner.co.il \
--to=efraim@flashner.co.il \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.