From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add sslh.
Date: Sun, 11 Sep 2016 23:23:03 -0400
Message-ID: <20160912032303.GA16878@jasmine>
References: <1473640328-28092-1-git-send-email-me@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjHq7-0001tW-Ex
	for guix-devel@gnu.org; Sun, 11 Sep 2016 23:23:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjHq1-0005aO-4A
	for guix-devel@gnu.org; Sun, 11 Sep 2016 23:23:22 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjHpx-0005Xr-TO
	for guix-devel@gnu.org; Sun, 11 Sep 2016 23:23:17 -0400
Content-Disposition: inline
In-Reply-To: <1473640328-28092-1-git-send-email-me@tobias.gr>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

On Mon, Sep 12, 2016 at 02:32:08AM +0200, Tobias Geerinckx-Rice wrote:
> * gnu/packages/networking.scm (sslh): New variable.

Interesting package!

> +         ;; Many of these files are mentioned in the man page. Install them.
> +         (add-after 'install 'install-documentation
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (doc (string-append out "/share/doc")))
> +                        (install-file "README.md" doc)
> +                        (for-each
> +                         (lambda (file)
> +                           (install-file file (string-append doc "/examples")))
> +                         (append (find-files "." "\\.cfg")
> +                                 (find-files "scripts" ".*"))))

Rather than '/share/doc', I think the doc variable should use
'/share/doc/sslh'. Otherwise, when installed into a profile, the
examples will be in '~/.guix-profile/share/doc'. It would be better if
they were in '~/.guix-profile/share/doc/sslh'.