Re: [PATCH] gnu: Add git-review.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

On Fri, Sep 09, 2016 at 06:09:40PM +0200, Clément Lassieur wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > I found ssh and I found an instance of scp, so this should be better.
> 
> --8<---------------cut here---------------start------------->8---
> clement@lev ~/foo [env]# git-review -d 36373
> Downloading refs/changes/73/36373/1 from gerrit
> Cannot fetch patchset contents
> 
> Does specified change number belong to this project?
> 
> The following command failed with exit code 128
>     "/gnu/store/...-git-2.10.0/bin/git fetch gerrit refs/changes/73/36373/1"
> -----------------------
> error: cannot run ssh: No such file or directory
> fatal: unable to fork
> -----------------------
> clement@lev ~/foo [env]# /gnu/store/...-git-2.10.0/bin/git remote -v                           
> gerrit  ssh://bar (fetch)
> gerrit  ssh://bar (push)
> --8<---------------cut here---------------end--------------->8---
> 
> It looks like ssh isn't hardcoded within git either. Is it worth doing
> this for git-review then?

This looks like you are using ssh for talking to the remote server, in
which case it would exist outside of git-review. Or did I misunderstand
it?

It does seem that wrapping the program would be easier than trying to
fing regexes that work to patching only certain instances of other
programs.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]