From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add darkhttpd.
Date: Fri, 9 Sep 2016 16:41:58 -0400
Message-ID: <20160909204158.GA4337@jasmine>
References: <20160909195623.12889-1-arunisaac@systemreboot.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57123)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1biScr-0004wN-5o
	for guix-devel@gnu.org; Fri, 09 Sep 2016 16:42:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1biScm-0007Hp-2X
	for guix-devel@gnu.org; Fri, 09 Sep 2016 16:42:17 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45023)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1biScj-0007Fi-NY
	for guix-devel@gnu.org; Fri, 09 Sep 2016 16:42:12 -0400
Content-Disposition: inline
In-Reply-To: <20160909195623.12889-1-arunisaac@systemreboot.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: guix-devel@gnu.org

On Sat, Sep 10, 2016 at 01:26:23AM +0530, Arun Isaac wrote:
> * gnu/packages/web.scm (darkhttpd): New variable.

Hi, thank you for this patch!

> +     `(#:tests? #f

When we disable the tests, we have to leave a comment explaining why. It
can be as simple as "No test suite" if that is the case.

> +         (replace 'configure
> +           (lambda _ (setenv "CC" "gcc")))

This has the effect of setting the CC variable and skipping any other
'configure' actions. Is this intended? If there is no './configure'
script or similar tool, this environment variable could be set in
#:make-flags or in a 'setenv' phase.

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +               (mkdir-p bin)
> +               (copy-file "darkhttpd" (string-append bin "/darkhttpd"))))))))

mkdir-p and copy-file and be replaced with install-file.

> +    (description "darkhttpd is a simple static web server.  It is
> +standalone and does not need inetd or ucspi-tcp.  It does not need any
> +config files -- you only have to specify the www root.")

You can make an 'em dash' in Texinfo like this:
"...config files---you only..."

> +    (home-page "https://unix4lyfe.org/darkhttpd/")
> +    (license l:bsd-2)))

The license on the main source file is the ISC license:
https://unix4lyfe.org/gitweb/darkhttpd/blob/HEAD:/darkhttpd.c

Can you send an updated patch?