From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 1/2] gnu: Add edi. Date: Fri, 9 Sep 2016 08:22:03 +0300 Message-ID: <20160909052203.GM12493@macbook42.flashner.co.il> References: <20160908104439.17877-1-efraim@flashner.co.il> <20160908104439.17877-2-efraim@flashner.co.il> <20160908234127.43d82356@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b/Q3JWIUAuLE0ZFy" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biEGX-00083A-28 for guix-devel@gnu.org; Fri, 09 Sep 2016 01:22:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biEGT-0004nU-Qh for guix-devel@gnu.org; Fri, 09 Sep 2016 01:22:16 -0400 Received: from flashner.co.il ([178.62.234.194]:58741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biEGT-0004m1-F9 for guix-devel@gnu.org; Fri, 09 Sep 2016 01:22:13 -0400 Content-Disposition: inline In-Reply-To: <20160908234127.43d82356@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org --b/Q3JWIUAuLE0ZFy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2016 at 11:41:27PM -0500, Eric Bavier wrote: > On Thu, 8 Sep 2016 13:44:38 +0300 > Efraim Flashner wrote: >=20 > > * gnu/packages/enlightenment.scm (edi): New variable. > > --- > > gnu/packages/enlightenment.scm | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > >=20 > > diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenmen= t.scm > > index 7cd11b5..a0c5a83 100644 > > --- a/gnu/packages/enlightenment.scm > > +++ b/gnu/packages/enlightenment.scm > > @@ -275,3 +275,29 @@ Libraries stack (eo, evas, ecore, edje, emotion, e= thumb and elementary).") > > =20 > > (define-public python2-efl > > (package-with-python2 python-efl)) > > + > > +(define-public edi > > + (package > > + (name "edi") > > + (version "0.4.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (list > > + (string-append "https://download.enlightenment.org/rel/= apps/edi" > > + "/edi-" version ".tar.bz2") > > + (string-append "https://github.com/ajwillia-ms/edi/rele= ases/" > > + "download/v" version "/edi-" version ".t= ar.bz2"))) > > + (sha256 > > + (base32 > > + "02d8hplcviayri8fxws56n362k6zqsf62v8pbn5sbgwrmkqwybhc")))) > > + (build-system gnu-build-system) > > + (native-inputs `(("pkg-config" ,pkg-config))) > > + (inputs `(("efl" ,efl))) >=20 > Apparently EDI can use libclang for syntax highlighting. Would that be > useful enough to add clang as an input? It would. I was worried about how big clang is compared to the rest of the package, but with the shared libraries bringing its size down it should be good. >=20 > > + (home-page "https://www.enlightenment.org/about-edi") > > + (synopsis "Development environment using the EFL") >=20 > I think its best (and the guix manual suggests) to avoid acronyms in > the package synopsis. Maybe: "Development environment for > Enlightenment"? >=20 They try to draw (somewhat of) a distinction beween the libraries and the desktop, but considering the description blurs it again this sounds good. > > + (description "EDI is a development environment designed for and bu= ilt using > > +the EFL. It's aim is to create a new, native development environment = for Linux > > +that trys to lower the barrier to getting involved in Enlightenment de= velopment > ^^^^ > "tries" >=20 > > +and in creating apps based on the EFL suite.") > ^^^^ > That word makes me cringe every time. >=20 > > + (license license:gpl2))) >=20 > According to COPYING, the code in 'data/extra/skeleton' is > public-domain. The other GPLv2 source doesn't appear to contain > license headers, so I think we're allowed to say gpl2+. There's also a > COPYING.LGPL file, the header of which say it applies to "Elm_Code", > but I can't seem to find where that code lives. And then the > edi/packaging/pkgbuild/PKGBUILD file has "license=3D('WTFPL')" in it. I > haven't looked at the other enlightenment software, do they all have > license situations like this? >=20 > Could you look into it some more and get some clarification? >=20 elm_code got removed after 0.3.0 but the license wasn't. the skeleton i believe is for if you just want a new, "default" EFL package, so while it gets included in the install, to me it seems more like text than code. Then again its there so I should mention it. I'm not sure why it says WTFPL in their PKGBUILD file but I'll ask about it. Most of their programs are light in license headers. > Thanks, > `~Eric --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --b/Q3JWIUAuLE0ZFy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJX0kb0AAoJEPTB05F+rO6TZ4wQAI/Fquu9JsKpYMiH5e49Azty eXptmJ5KMNLXk8O2pEfUAZ/YQyuC3TwE/rb3bZhG6zOPOsoI5znEAZk7s1Rbhl/b n9JoB4W4S0zLV4GaKVfcfkpaCjdYcyagoJnDBLnGAEH2DeuxRMcvCPE/PaBNJ2Pq jXNyErh8YY5mvmmsRBzVSGWVhVLT1jSINY1kmLRFvXQNQzbIB3El37/XIn+SHr99 h8YE7p7NmSlCAjvtBkZs3j8iNEFggjWo9nuS+XJSqusqhkyNans+AIGMnO+i/Y/F WOshsX8+jwm6yLxrQsQCHcM5HE+EVrkNMF8p0TMSB6lmmYF6IzdzcpL4PIs58Hzv 64mENxpj5YQJZA+pHnTWsHx7jl4n79Ti3U1jkzG5sOV0B6U5JIHhOZjGe6vhvoxL zaYyi77tMBNELpJiq34rNMQSVr/hhzC85AD57FSGeGNgT927qPILPz0IXBYE2uum +DxzcEP/an9/8IYZvxUhhXqObjMBsKHkXwf6krwV6tBtGLxiYJyAd3aQdOyNmhFz aw3oqzTLSpz6YSXYVa7Lsh4TlRBdza+EMBdHMmV0T9VSohn0bGA64LK7WAAlVm+1 tm0dbz/UEO8SticjOMJT8pJmwbun/ozKpeK+NIO2+XiSbCZNvBlkR1ZDRO1cdDC+ ZzvJvdyogpJkGCLga1Iv =CC4v -----END PGP SIGNATURE----- --b/Q3JWIUAuLE0ZFy--