From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH] gnu: Simplify dtc package definition. Date: Thu, 8 Sep 2016 19:55:39 +0200 Message-ID: <20160908195539.4d47016d@scratchpost.org> References: <20160907074631.3771-1-dannym@scratchpost.org> <20160907110141.3b27eca7@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3YG-0004nN-32 for guix-devel@gnu.org; Thu, 08 Sep 2016 13:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3YA-00033K-WD for guix-devel@gnu.org; Thu, 08 Sep 2016 13:55:51 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:59202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3YA-000332-NG for guix-devel@gnu.org; Thu, 08 Sep 2016 13:55:46 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel Hi David, On Thu, 8 Sep 2016 17:09:12 +0200 David Craven wrote: > Why aren't you using git format-patch? :) > > git format-patch -1 > git send-email *.patch --to guix-devel@gnu.org > > is what I do... That's exactly what I do too - the exact same commands. I don't know what magical options other people use but that's how it always comes out for me. I usually manually copy&paste the subject back down into the body - but this time I forgot. Regardless, that was a bona fide git format-patch AND git send-email E-Mail. On the other hand, Linux people also told me about my git format-patch settings being "wrong" - and indeed they are different than the ones I use to submit to Guix. What are the settings you use / we should use? Mine are: $ git config --global -l |grep ^format format.subjectprefix=FIXME format.numbered=auto format.signoff=false format.coverletter=auto format.signature= format.attach= And the git-format-patch executable is built from GuixSD svn master hydra from a few days ago...