From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add git-review. Date: Thu, 8 Sep 2016 20:58:01 +0300 Message-ID: <20160908175801.GJ12493@macbook42.flashner.co.il> References: <20160908070630.18458-1-clement@lassieur.org> <439770f1-4691-45ac-348e-9e41bc126e0d@uq.edu.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="451BZW+OUuJBCAYj" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3aY-0006gy-Gb for guix-devel@gnu.org; Thu, 08 Sep 2016 13:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3aU-0003XQ-C2 for guix-devel@gnu.org; Thu, 08 Sep 2016 13:58:14 -0400 Received: from flashner.co.il ([178.62.234.194]:45875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3aU-0003UV-0J for guix-devel@gnu.org; Thu, 08 Sep 2016 13:58:10 -0400 Content-Disposition: inline In-Reply-To: <439770f1-4691-45ac-348e-9e41bc126e0d@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Lassieur --451BZW+OUuJBCAYj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote: > Hi there, thanks for the patch. I do not have any experience with Gerrit = but > some comments below: >=20 >=20 > On 08/09/16 17:06, Cl=C3=A9ment Lassieur wrote: > > [..] > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "https://pypi.python.org/packages/source/g/git-review/git= -review-" > > + version ".tar.gz")) >=20 > Rather: (uri (pypi-uri "git-review" version)) >=20 > > + (sha256 > > + (base32 > > + "07d1jn9ryff5j5ic6qj5pbk10m1ccmpllj0wyalrcms1q9yhlzh8")))) > > + (build-system python-build-system) > > + (arguments `(#:tests? #f)) ; tests require a running Gerrit server > > + (native-inputs > > + `(("python-pbr" ,python-pbr))) > > + (inputs > > + `(("python-requests" ,python-requests) > > + ("git" ,git))) >=20 > I think including git simply as an input is problematic because git-review > calls git via 'subprocess', as evidenced by >=20 > $ ./pre-inst-env guix environment -C --ad-hoc git-review > $ git-review > [..] > File "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/pyth= on3.4/subprocess.py", > line 1457, in _execute_child > raise child_exception_type(errno_num, err_msg) > FileNotFoundError: [Errno 2] No such file or directory: 'git' >=20 > So, I think we need to patch the source code to call the full path to git, > or otherwise wrap the 'git-review' executable. >=20 > > + (home-page "http://docs.openstack.org/infra/git-review/") > > + (synopsis "Command-line tool for Gerrit") > > + (description > > + "Git-review is a command-line tool that helps submitting Git bran= ches to > > +Gerrit for review, or fetching existing ones.") > > + (license asl2.0))) > Otherwise seems OK to me. Can you test with environment -C -N? > ben >=20 Oh no! I just pushed this. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --451BZW+OUuJBCAYj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJX0aalAAoJEPTB05F+rO6T/O0P/R6Q/UqqEeW0Yu7M0MBbD7Np ShcWP14ZE9tMmjhuEAJs4jK6LaHSgwxFaqvbuMXiDfQDEKaezHhoFfx49mL/pnWQ aHVJ5PDx1bjb02JAP5tJtudGoblrI3pnpxKvVv3lpTG80DgmkhYqZ0Op0vCJ38FM Rp1VGr/uIzgIbNDdAPi0BGVtyAlM3rDGIHNT9arrfBlGmLTs+WKEms6dtilatZ8b 4BsgpOfE0Ge2sHkU7PFDZJaePxq69WPnzEXgOpThY+J0cRZ+6UA+JAIa7iygte5I emWj4n617rz8jDJBcytwfIX7cuNA75n2gqWSToyF/ump7eIMHW9j0WXuSg/WQqiX oD9aN/DFtCu8zYQT8HnufAnvcL5sVYdIJMeoS9KkYDbSjtNSd0r5qBcbQI9R9zXT P1G1NPKJzKi+kYUwhApt6eUP+TnrmJpD9Qya10/xGIxFPc46a2AQ2H+G9DX3yBcs adK3fb3y6fpPvxhWR6q0PUNnag2Mx87vTNaZwDlLU7n+7/b0tBZ/SvUzBsCtpik0 Zm0D4RePoWwLbd6a5FEtaN9Q5KhZOTdpEx8o0+19X45shS6VPK/i4nEcLrEKq6W/ oq1HTsZgBc6eZqkQT8UsdUO7T1gQcHjlQeUyhRcP8jrH3CvbmEEf+2M1q3Rn0LgV jtpMFQSQL++j+RyF6An7 =2bQT -----END PGP SIGNATURE----- --451BZW+OUuJBCAYj--