From: Efraim Flashner <efraim@flashner.co.il>
To: Erik Edrosa <erik.edrosa@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add utox.
Date: Thu, 8 Sep 2016 11:56:23 +0300 [thread overview]
Message-ID: <20160908085623.GC12493@macbook42.flashner.co.il> (raw)
In-Reply-To: <20160908010002.5017-4-erik.edrosa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2899 bytes --]
On Wed, Sep 07, 2016 at 09:00:02PM -0400, Erik Edrosa wrote:
> * gnu/packages/messaging.scm (utox): New variable.
> ---
> gnu/packages/messaging.scm | 44 +++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index b95239a..27086c8 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -64,7 +64,9 @@
> #:use-module (gnu packages tls)
> #:use-module (gnu packages icu4c)
> #:use-module (gnu packages video)
> - #:use-module (gnu packages xiph))
> + #:use-module (gnu packages xiph)
> + #:use-module (gnu packages audio)
> + #:use-module (gnu packages fontutils))
>
> (define-public libotr
> (package
> @@ -612,4 +614,44 @@ protocols.")
> (license gpl3+)
> (home-page "https://tox.chat"))))
>
> +(define-public utox
> + (package
> + (name "utox")
> + (version "0.9.8")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/GrayHatter/uTox/archive/v"
> + version ".tar.gz"))
This one also needs a 'file-name' field, otherwise it'll save the source
as 'hash-v0.9.8.tar.gz' and we'll have no idea what it is.
> + (sha256
> + (base32
> + "13hfqbwzcgvfbvf9yjm62aqsvxnpqppb50c88sys43m7022yqcsy"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:make-flags (list (string-append "PREFIX=" %output)
> + "CC=gcc")
> + #:tests? #f
> + #:phases (alist-delete 'configure %standard-phases)))
Same as the last one, why no tests? Also, 'modify-phases'
> + (inputs
> + `(("libtoxcore" ,libtoxcore)
> + ("filteraudio" ,filteraudio)
> + ("dbus" ,dbus)
> + ("openal" ,openal)
> + ("libvpx" ,libvpx)
> + ("libsodium" ,libsodium)
> + ("freetype" ,freetype)
> + ("fontconfig" ,fontconfig)
> + ("v4l-utils" ,v4l-utils)
> + ("libx11" ,libx11)
> + ("libxext" ,libxext)
> + ("libxrender" ,libxrender)))
more of an aesthetic thing, can you make the inputs alphabetized?
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (synopsis "Lightweight Tox client")
> + (description "The lightest and fluffiest Tox client. Tox is a
> +distributed and secure instant messenger with audio and video chat
> +capabilities.")
> + (home-page "http://utox.org/")
> + (license gpl3+)))
I believe it is just gpl3
> +
> ;;; messaging.scm ends here
> --
> 2.10.0
>
This one also looks really good. Can you send an updated patch?
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-08 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 0:59 [PATCH 0/3] Add utox Erik Edrosa
2016-09-08 1:00 ` [PATCH 1/3] gnu: openal: Update to 1.17.2 Erik Edrosa
2016-09-08 9:02 ` Efraim Flashner
2016-09-08 1:00 ` [PATCH 2/3] gnu: Add filteraudio Erik Edrosa
2016-09-08 8:40 ` Efraim Flashner
2016-09-08 1:00 ` [PATCH 3/3] gnu: Add utox Erik Edrosa
2016-09-08 8:56 ` Efraim Flashner [this message]
2016-09-09 1:02 ` [PATCH v2 2/3] gnu: Add filteraudio Erik Edrosa
2016-09-09 1:02 ` [PATCH v2 3/3] gnu: Add utox Erik Edrosa
2016-09-10 19:40 ` Efraim Flashner
2016-09-10 19:40 ` [PATCH v2 2/3] gnu: Add filteraudio Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908085623.GC12493@macbook42.flashner.co.il \
--to=efraim@flashner.co.il \
--cc=erik.edrosa@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.