all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: 01/01: gnu: go: Update to 1.7.
       [not found] ` <20160906191432.E5F9622005F@vcs.savannah.gnu.org>
@ 2016-09-06 20:33   ` Leo Famulari
  0 siblings, 0 replies; only message in thread
From: Leo Famulari @ 2016-09-06 20:33 UTC (permalink / raw)
  To: guix-devel

On Tue, Sep 06, 2016 at 07:14:32PM +0000, Efraim Flashner wrote:
>     gnu: go: Update to 1.7.
>     
>     * gnu/packages/golang.scm (go-1.6): Update to 1.7, with corresponding
>       minor changes to prebuild phase, and rename variable to...
>       (go-1.7): ...this new variable.
>       (go): Inherit from new "go-1.7".

I'm very glad that we have the latest Go, but this commit message did
not follow our standards, which are linked to in the manual, section 8.5
Submitting Patches.

https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

The changelog should have mentioned that we disabled more tests, patched
more shebangs, and adjusted the path to the "testar script".

I don't think we should revert and rewrite it, but it's something to
keep in mind for the future. Having a standardized commit log makes it a
lot easier to read the history of the project.

Anyways, thank you Petter for handling this upgrade!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-09-06 21:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160906191432.8725.94870@vcs.savannah.gnu.org>
     [not found] ` <20160906191432.E5F9622005F@vcs.savannah.gnu.org>
2016-09-06 20:33   ` 01/01: gnu: go: Update to 1.7 Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.