From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: 02/11: activation: Allow home directories to be created under /var/lib. Date: Tue, 6 Sep 2016 14:48:02 -0400 Message-ID: <20160906184802.GA1049@jasmine> References: <20160906155317.12854.59323@vcs.savannah.gnu.org> <20160906155317.D019622017C@vcs.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLQH-0006N5-UZ for guix-devel@gnu.org; Tue, 06 Sep 2016 14:48:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhLQ6-0000kS-EK for guix-devel@gnu.org; Tue, 06 Sep 2016 14:48:39 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhLPx-0000g4-GC for guix-devel@gnu.org; Tue, 06 Sep 2016 14:48:30 -0400 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id F3C1DCCE89 for ; Tue, 6 Sep 2016 14:48:03 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20160906155317.D019622017C@vcs.savannah.gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org On Tue, Sep 06, 2016 at 03:53:17PM +0000, David Craven wrote: > commit 6526d43ea4fb0cd151a0d5e9a072c651c1c963d1 > Author: David Craven > Date: Fri Aug 26 21:45:57 2016 +0200 > > activation: Allow home directories to be created under /var/lib. > > * gnu/build/activation.scm (activate-user+groups): Make sure /var/lib > exists. > --- > gnu/build/activation.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/build/activation.scm b/gnu/build/activation.scm > index 10aa58d..7dc40b0 100644 > --- a/gnu/build/activation.scm > +++ b/gnu/build/activation.scm > @@ -233,6 +233,9 @@ numeric gid or #f." > ;; 'groupadd' aborts if the file doesn't already exist. > (touch "/etc/group") > > + ;; Allow home directories to be created under /var/lib. > + (mkdir "/var/lib") > + > ;; Create the root account so we can use 'useradd' and 'groupadd'. > (activate-user (find (match-lambda > ((name (? zero?) _ ...) #t) > This would fail when /var/lib already existed. I fixed it by using mkdir-p in a7199b7d994433eaabb989690887b921d053d761. Yesterday was my first time using the system tests: https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html#Running-the-Test-Suite I assume they would have caught this, but I'm not sure. They definitely would have caught my breakage of GRUB when I updated QEMU recently ;)