From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH] gnu: Add u-boot.
Date: Wed, 31 Aug 2016 22:55:34 +0200
Message-ID: <20160831225534.58cf56b9@scratchpost.org>
References: <20160829144822.3188-1-david@craven.ch>
	<20160829161626.25216-1-david@craven.ch> <87eg54llie.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bfCXu-0007N0-MR
	for guix-devel@gnu.org; Wed, 31 Aug 2016 16:55:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bfCXp-0003NP-Kq
	for guix-devel@gnu.org; Wed, 31 Aug 2016 16:55:42 -0400
In-Reply-To: <87eg54llie.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Hi Ludo,

On Wed, 31 Aug 2016 22:40:57 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> > +           (lambda* (#:key outputs make-flags #:allow-other-keys)
> > +             (let ((configname (string-append ,board "_defconfig"))) =
=20
>=20
> Should be =E2=80=98config-name=E2=80=99 per our conventions, but =E2=80=
=98config=E2=80=99 is probably
> enough.
>=20
> > +               (if (file-exists? (string-append "configs/" configname))
> > +                   (zero? (apply system* "make" `(,@make-flags ,config=
name)))
> > +                   (begin
> > +                     (display "Invalid boardname. Valid boardnames wou=
ld have been:")
>
> =E2=80=9Cboard name=E2=80=9D (two words).

> > +                    (copy-file file-path target-file-path)))
> > +                uboot-files))))))))) =20
>=20
> s/-path//               =20

For the record, a filename (or file path) is something completely different=
 from a file. It makes no sense to call a filename "file". Likewise, a boar=
dname is the name of a board. It's not the board. A configname is the name =
of a config [file]. "config" would be the configuration itself.

To develop this habit has taken a long time for me and it has paid off well.

I'm not totally against naming filenames "file" - or "f" for that matter - =
but I distinguish for good reason.

Also when adapting gnu/system.scm etc for U-Boot I spent lots of time findi=
ng out what are confignames and what are configurations because it likewise=
 does not distinguish.

A rose by any other name would smell as sweet, you know :)