From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add dlib. Date: Wed, 31 Aug 2016 15:09:08 -0400 Message-ID: <20160831190908.GD12396@jasmine> References: <20160818202353.GB2393@jasmine> <8737m1yqru.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160821201757.GA21038@jasmine> <6004b842-2434-9cdc-7a31-04231eac5941@uq.edu.au> <87k2f957wt.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <8760qr5o8n.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87eg5e4g4r.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160824172608.GA24668@jasmine> <878tvm2ddh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87mvjuz5ae.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfAt6-0003IV-K2 for guix-devel@gnu.org; Wed, 31 Aug 2016 15:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfAt0-00085Z-VP for guix-devel@gnu.org; Wed, 31 Aug 2016 15:09:27 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfAsz-00081k-Ik for guix-devel@gnu.org; Wed, 31 Aug 2016 15:09:22 -0400 Content-Disposition: inline In-Reply-To: <87mvjuz5ae.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel , Alex Kost On Tue, Aug 30, 2016 at 03:43:05PM +0100, Marius Bakke wrote: > Shogun failed to build in this run. I don't have time to investigate > further, so picking the OpenBLAS update is not very appealing. > > Instead I opted to disable the test that fails with lapack (and without, > on Hydra), since it's one specific openblas operation that is not unique > to dlib. I think it's an acceptable tradeoff, to give users the full > dlib functionality, and have the segfault "sort itself" when > core-updates lands in master. Okay, this sounds fine to me. > Below is a patch which disables these tests (and the above segfault) for > 19.1, rather than backporting the patches from dlib master branch. > > One note about the patch: I could not figure out how to pass the list of > tests as arguments to `substitute*`, so currently it calls `substitute*` > for each of them. Any tips to prevent this? Not from me — Calling all seasoned Schemers to thread :) If nobody replies I will say this solution is fine. Changing the subject, you could disable the tests per-architecture. Look for uses of current-target-system and current-system for usage examples. But this is not absolutely required, IMO. > It also no longer builds the main application twice for tests. Thank you :)