From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: rofi: Update to 1.2.0.
Date: Wed, 31 Aug 2016 14:47:33 -0400
Message-ID: <20160831184733.GA12396@jasmine>
References: <87zintx9u1.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAY9-0007c4-Nn
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:47:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAY4-0003ih-QK
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:47:49 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAY3-0003gZ-Gk
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:47:44 -0400
Content-Disposition: inline
In-Reply-To: <87zintx9u1.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

On Wed, Aug 31, 2016 at 04:00:06PM +0100, Marius Bakke wrote:
> Greetings Guix,
> 
> I am the maintainer of this package in NixOS and figured I could update
> it here as well, since it was non-trivial.

Thanks!

> The libx11 dependency is dropped in favour of a new xcb-util-xrm module.
> I added the latter to xdisorg since it's not listed on xcb.fd.o proper,
> but followed the convention of the other xcb-util-* libraries.
> 
> Disclaimer: untested, apart from building with rounds=2.

Okay!

> Subject: [PATCH 1/2] gnu: Add xcb-util-xrm.
> 
> * gnu/packages/xdisorg.scm (xcb-util-xrm): New variable.

This actually bundles m4, even if it doesn't use it. Can you delete that
'm4' directory in an origin snippet? There's an example in the calibre
package definition.

> +              (uri (string-append
> +                    "https://github.com/Airblader/xcb-util-xrm/releases/download"

Also this line a bit too long :)

Otherwise LGTM!