From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Add bind Date: Wed, 31 Aug 2016 20:38:53 +0200 Message-ID: <20160831183852.GA6968@jocasta.intra> References: <1472574964-16954-1-git-send-email-jmd@gnu.org> <20160831175211.GE28096@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfAPw-00045I-QV for guix-devel@gnu.org; Wed, 31 Aug 2016 14:39:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfAPu-0001ps-Kr for guix-devel@gnu.org; Wed, 31 Aug 2016 14:39:19 -0400 Content-Disposition: inline In-Reply-To: <20160831175211.GE28096@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org, John Darrington --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for the comments, On Wed, Aug 31, 2016 at 01:52:11PM -0400, Leo Famulari wrote: On Tue, Aug 30, 2016 at 06:36:04PM +0200, John Darrington wrote: > * gnu/packages/networking.scm (bind): New variable. =20 Hi, thanks for this patch! I think it can go in the DNS module. =20 I wonder, how does it relate to the BIND that replaces the bundled BIND in isc-dhcp, which I've noticed often requires security updates? I don't think it relates at all, except that it is produced by the same gro= up. However, I noticed in that module, there is bind-utils, which provides about half of what my patch does, and IMO is unecessarily complicated. I suppose= this was done because somebody wanted to provide the DNS query tools without the DNS server. =20 I think this would be better achieved by having separate outputs bind:utils= and bind:daemon > + (modify-phases %standard-phases > + (replace 'check > + (lambda _ > + (zero? (system* "make" "force-test"))))))) =20 Does "force-test" mean that the test suite will return success even if there are some failures? If so, this should explicitly stated in a comment. Apparently, some tests cannot be run unless one makes some local hacks=20 as root. force-test skips those tests which require that. J' --=20 Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfHJDwACgkQimdxnC3oJ7OengCdEBLv2ba1Kp9d/szO2yKNgmq9 YSUAn1E7xZ0atl+miPjkYPeA5hAJMRHf =Wpgu -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--