From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add bind
Date: Wed, 31 Aug 2016 13:52:11 -0400
Message-ID: <20160831175211.GE28096@jasmine>
References: <1472574964-16954-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bf9gd-0004wx-8q
	for guix-devel@gnu.org; Wed, 31 Aug 2016 13:52:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bf9gX-0001Ol-AI
	for guix-devel@gnu.org; Wed, 31 Aug 2016 13:52:30 -0400
Content-Disposition: inline
In-Reply-To: <1472574964-16954-1-git-send-email-jmd@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

On Tue, Aug 30, 2016 at 06:36:04PM +0200, John Darrington wrote:
> * gnu/packages/networking.scm (bind): New variable.

Hi, thanks for this patch! I think it can go in the DNS module.

I wonder, how does it relate to the BIND that replaces the bundled BIND
in isc-dhcp, which I've noticed often requires security updates?

> +    (description "BIND is an implementation of the Domain Name System (DNS)
> +protocols for the Internet.  It is a reference implementation of those
> +protocols, but it is also production-grade software, suitable for use in
> +high-volume and high-reliability applications. The name BIND stands for
> +"Berkeley Internet Name Domain", because the software originated in the early
> +1980s at the University of California at Berkeley.")

The descriptions needs the quotation marks around the acronym
description to be escaped. Otherwise, it doesn't work for me.

> +              (uri (string-append
> +                    "ftp://ftp.isc.org/isc/bind9/" version "/" name "-"
> +                    version ".tar.gz"))

This server is unavailable over IPv6 connections:

Starting download of /gnu/store/lhwlfx4qp94pn5d0xpflqib1cy2c4bhp-bind-9.10.4-P2.tar.gz
>From ftp://ftp.isc.org/isc/bind9/9.10.4-P2/bind-9.10.4-P2.tar.gz...
ERROR: Throw to key `ftp-error' with args `(#<input-output: socket 6> "PASV" 425 "You cannot use PASV on IPv6 connections. Use EPSV instead.\r")'.

I wonder if there is a better URL?

> +     (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (zero? (system* "make" "force-test")))))))

Does "force-test" mean that the test suite will return success even if
there are some failures? If so, this should explicitly stated in a
comment.