From: Eric Bavier <ericbavier@openmailbox.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH]: Add bambam
Date: Wed, 31 Aug 2016 12:21:16 -0500 [thread overview]
Message-ID: <20160831122116.0f7e5581@openmailbox.org> (raw)
In-Reply-To: <87k2exe7xy.fsf@gmail.com>
On Wed, 31 Aug 2016 10:03:37 +0300
Alex Kost <alezost@gmail.com> wrote:
> Only a couple of small things :-)
>
> [...]
> > +(define-public bambam
> > + (package
> > + (name "bambam")
> > + (version "0.5")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append "https://github.com/porridge/bambam/archive/"
> > + version ".tar.gz"))
> > + (file-name (string-append name "-" version ".tar.gz"))
> > + (sha256
> > + (base32
> > + "10w110mjdwbvddzihh9rganvvjr5jfiz8cs9n7w12zndwwcc3ria"))))
> > + (build-system python-build-system)
> > + (arguments
> > + `(#:python ,python-2
> > + #:tests? #f ; no tests
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'build)
> > + (add-before 'install 'patch-data-dir-location
> > + (lambda _
> > + (substitute* "bambam.py"
> > + (("'data'")
> > + "'../share/bambam/data'"))
>
> This is an unusual indentation, I would write:
>
> (substitute* "bambam.py"
> (("'data'") "'../share/bambam/data'"))
>
>
> > + #t))
> > + (replace 'install
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (share (string-append out "/share")))
> > + (mkdir-p bin)
> > + (copy-file "bambam.py" (string-append bin "/bambam"))
> > + (install-file "bambam.6" (string-append share "/man/man6"))
> > + (copy-recursively "data" (string-append share "/bambam/data")))
> > + #t))
> > + (add-after 'install 'wrap-binary
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin/bambam")))
> > + (wrap-program bin
> > + `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))))
> > + #t)))))
> > + (inputs
> > + `(("python-pygame" ,python-pygame)))
> > + (home-page "https://github.com/porridge/bambam")
> > + (synopsis "keyboard mashing and doodling game for babies")
> Keyboard
> "guix lint" reported it should begin with an upper-case letter.
>
> > + (description "Bambam is a simple baby keyboard (and gamepad) masher
> > +application that locks the keyboard and mouse and instead displays bright
> > +colors, pictures, and sounds.")
> > + (license license:gpl3+)))
>
Since I accidentaly pushed this patch with another batch, I went ahead
and made these changes. I also removed the wrap-binary phase, which is
handled by python-build-system. Pushed in
46a0622481c398bd9337522e93f6f9082d2b9015.
Thanks,
`~Eric
prev parent reply other threads:[~2016-08-31 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 20:43 [PATCH]: Add bambam Efraim Flashner
2016-08-30 21:11 ` Leo Famulari
2016-08-30 21:29 ` Efraim Flashner
2016-08-31 6:56 ` Alex Kost
2016-08-31 7:03 ` Alex Kost
2016-08-31 17:21 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831122116.0f7e5581@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.