all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.
@ 2016-08-30 23:34 David Craven
  2016-08-30 23:34 ` [PATCH] gnu: sqlite: Update to 3.14.1 David Craven
  2016-08-31 18:52 ` [PATCH] gnu: sqlite: Enable DBSTAT_VTAB Leo Famulari
  0 siblings, 2 replies; 6+ messages in thread
From: David Craven @ 2016-08-30 23:34 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag
  -DSQLITE_ENABLE_DBSTAT_VTAB.
---
 gnu/packages/databases.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index a04c375..ce51d28 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -520,10 +520,12 @@ for example from a shell script.")
    (inputs `(("readline" ,readline)))
    (arguments
     `(#:configure-flags
-      ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to
-      ;; CFLAGS.  GNU Icecat will refuse to use the system SQLite unless these
-      ;; options are enabled.
-      '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY")))
+      ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and
+      ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS.  GNU Icecat will refuse
+      ;; to use the system SQLite unless these options are enabled.
+      (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE "
+                           "-DSQLITE_ENABLE_UNLOCK_NOTIFY "
+                           "-DSQLITE_ENABLE_DBSTAT_VTAB"))))
    (home-page "http://www.sqlite.org/")
    (synopsis "The SQLite database management system")
    (description
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] gnu: sqlite: Update to 3.14.1.
  2016-08-30 23:34 [PATCH] gnu: sqlite: Enable DBSTAT_VTAB David Craven
@ 2016-08-30 23:34 ` David Craven
  2016-08-31 18:50   ` Leo Famulari
  2016-08-31 18:52 ` [PATCH] gnu: sqlite: Enable DBSTAT_VTAB Leo Famulari
  1 sibling, 1 reply; 6+ messages in thread
From: David Craven @ 2016-08-30 23:34 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/databases.scm (sqlite): Update to 3.14.1.
---
 gnu/packages/databases.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 3d2d130..a04c375 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -484,7 +484,7 @@ for example from a shell script.")
 (define-public sqlite
   (package
    (name "sqlite")
-   (version "3.13.0")
+   (version "3.14.1")
    (source (origin
             (method url-fetch)
             ;; TODO: Download from sqlite.org once this bug :
@@ -515,7 +515,7 @@ for example from a shell script.")
                    ))
             (sha256
              (base32
-              "0sq88jbwsk48i41f7m7rkw9xvijq011nsbs7pl49s31inck70yg2"))))
+              "19j73j44akqgc6m82wm98yvnmm3mfzmfqr8mp3n7n080d53q4wdw"))))
    (build-system gnu-build-system)
    (inputs `(("readline" ,readline)))
    (arguments
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: sqlite: Update to 3.14.1.
  2016-08-30 23:34 ` [PATCH] gnu: sqlite: Update to 3.14.1 David Craven
@ 2016-08-31 18:50   ` Leo Famulari
  0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2016-08-31 18:50 UTC (permalink / raw)
  To: David Craven; +Cc: guix-devel

On Wed, Aug 31, 2016 at 01:34:31AM +0200, David Craven wrote:
> * gnu/packages/databases.scm (sqlite): Update to 3.14.1.

Thanks! I noticed that Efraim did the same update on core-updates with
66a2a01ad3ad21a5b192814a71b899036ccc001

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.
  2016-08-30 23:34 [PATCH] gnu: sqlite: Enable DBSTAT_VTAB David Craven
  2016-08-30 23:34 ` [PATCH] gnu: sqlite: Update to 3.14.1 David Craven
@ 2016-08-31 18:52 ` Leo Famulari
  2016-09-01 20:41   ` Mark H Weaver
  1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2016-08-31 18:52 UTC (permalink / raw)
  To: David Craven; +Cc: guix-devel

On Wed, Aug 31, 2016 at 01:34:30AM +0200, David Craven wrote:
> * gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag
>   -DSQLITE_ENABLE_DBSTAT_VTAB.
> ---
>  gnu/packages/databases.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a04c375..ce51d28 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -520,10 +520,12 @@ for example from a shell script.")
>     (inputs `(("readline" ,readline)))
>     (arguments
>      `(#:configure-flags
> -      ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to
> -      ;; CFLAGS.  GNU Icecat will refuse to use the system SQLite unless these
> -      ;; options are enabled.
> -      '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY")))
> +      ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and
> +      ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS.  GNU Icecat will refuse
> +      ;; to use the system SQLite unless these options are enabled.
> +      (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE "
> +                           "-DSQLITE_ENABLE_UNLOCK_NOTIFY "
> +                           "-DSQLITE_ENABLE_DBSTAT_VTAB"))))

When the new Icecat is released, I think we should graft this change
onto the master branch. This is because the new Icecat will fix a bunch
of security bugs.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.
  2016-08-31 18:52 ` [PATCH] gnu: sqlite: Enable DBSTAT_VTAB Leo Famulari
@ 2016-09-01 20:41   ` Mark H Weaver
  2016-09-01 21:03     ` David Craven
  0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2016-09-01 20:41 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

Leo Famulari <leo@famulari.name> writes:

> On Wed, Aug 31, 2016 at 01:34:30AM +0200, David Craven wrote:
>> * gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag
>>   -DSQLITE_ENABLE_DBSTAT_VTAB.
>> ---
>>  gnu/packages/databases.scm | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index a04c375..ce51d28 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -520,10 +520,12 @@ for example from a shell script.")
>>     (inputs `(("readline" ,readline)))
>>     (arguments
>>      `(#:configure-flags
>> -      ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to
>> -      ;; CFLAGS.  GNU Icecat will refuse to use the system SQLite unless these
>> -      ;; options are enabled.
>> -      '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY")))
>> +      ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and
>> +      ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS.  GNU Icecat will refuse
>> +      ;; to use the system SQLite unless these options are enabled.
>> +      (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE "
>> +                           "-DSQLITE_ENABLE_UNLOCK_NOTIFY "
>> +                           "-DSQLITE_ENABLE_DBSTAT_VTAB"))))
>
> When the new Icecat is released, I think we should graft this change
> onto the master branch. This is because the new Icecat will fix a bunch
> of security bugs.

I don't think grafting this will help, because IceCat will refuse to use
sqlite without the needed options at build time, when it sees the
original (ungrafted) version of sqlite.

Anyway, we should push this to core-updates.  David, would you like to
do that?

      Thanks,
        Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.
  2016-09-01 20:41   ` Mark H Weaver
@ 2016-09-01 21:03     ` David Craven
  0 siblings, 0 replies; 6+ messages in thread
From: David Craven @ 2016-09-01 21:03 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

Pushed as 73dc727ec8d2994aed2f011f89dbd89591ff35a8.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-09-01 21:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-30 23:34 [PATCH] gnu: sqlite: Enable DBSTAT_VTAB David Craven
2016-08-30 23:34 ` [PATCH] gnu: sqlite: Update to 3.14.1 David Craven
2016-08-31 18:50   ` Leo Famulari
2016-08-31 18:52 ` [PATCH] gnu: sqlite: Enable DBSTAT_VTAB Leo Famulari
2016-09-01 20:41   ` Mark H Weaver
2016-09-01 21:03     ` David Craven

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.