From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add cfitsio
Date: Tue, 30 Aug 2016 16:47:18 -0400
Message-ID: <20160830204718.GB10937@jasmine>
References: <1472584872-19300-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bepwQ-0000D6-S9
	for guix-devel@gnu.org; Tue, 30 Aug 2016 16:47:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bepwM-0001T3-MM
	for guix-devel@gnu.org; Tue, 30 Aug 2016 16:47:29 -0400
Content-Disposition: inline
In-Reply-To: <1472584872-19300-1-git-send-email-jmd@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

On Tue, Aug 30, 2016 at 09:21:10PM +0200, John Darrington wrote:
> +       (uri (string-append
> +        "http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/" name version
> +        ".tar.gz")) 

I would indent this based on (string-append).

> +         (add-after 'unpack 'replace-slash-bin

I would call this "patch-paths" or something like that, in order to
communicate the intention.

Otherwise LGTM.