all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add cfitsio
Date: Tue, 30 Aug 2016 16:47:18 -0400	[thread overview]
Message-ID: <20160830204718.GB10937@jasmine> (raw)
In-Reply-To: <1472584872-19300-1-git-send-email-jmd@gnu.org>

On Tue, Aug 30, 2016 at 09:21:10PM +0200, John Darrington wrote:
> +       (uri (string-append
> +        "http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/" name version
> +        ".tar.gz")) 

I would indent this based on (string-append).

> +         (add-after 'unpack 'replace-slash-bin

I would call this "patch-paths" or something like that, in order to
communicate the intention.

Otherwise LGTM.

  parent reply	other threads:[~2016-08-30 20:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 19:21 [PATCH 1/3] gnu: Add cfitsio John Darrington
2016-08-30 19:21 ` [PATCH 2/3] gnu: Add wcslib John Darrington
2016-08-30 20:47   ` Leo Famulari
2016-08-31  6:42   ` Alex Kost
2016-09-12 13:44     ` Alex Kost
2016-09-12 15:40       ` John Darrington
2016-09-13  8:10         ` Alex Kost
2016-09-13 12:44           ` John Darrington
2016-08-30 19:21 ` [PATCH 3/3] gnu: Add gnuastro John Darrington
2016-08-30 20:45   ` Leo Famulari
2016-08-31  6:47   ` Alex Kost
2016-08-30 20:47 ` Leo Famulari [this message]
2016-08-31  6:45 ` [PATCH 1/3] gnu: Add cfitsio Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830204718.GB10937@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=jmd@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.