all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Matthew Jordan <matthewjordannm@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] Feed2maildir: Add feed2maildir
Date: Tue, 30 Aug 2016 15:19:31 -0400	[thread overview]
Message-ID: <20160830191931.GB7311@jasmine> (raw)
In-Reply-To: <87zio6f6bq.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>

On Sun, Aug 21, 2016 at 12:13:45PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 2/2] gnu: Add feed2maildir
> 
> * gnu/packages/mail.scm (python-feed2maildir): New variable.

Thanks!

I have the same feedback for this package as I did for
python-feedparser. Additional comments below.

> +    (arguments
> +     `(#:tests? #f))

When skipping tests, we must leave a code comment explaining why. It can
be as simple as "No test suite" if that's the case.

> +    (license
> +     (non-copyleft "https://github.com/sulami/feed2maildir/blob/master/LICENSE"))))

This is the ISC license.

      reply	other threads:[~2016-08-30 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21 16:13 [PATCH 2/2] Feed2maildir: Add feed2maildir Matthew Jordan
2016-08-30 19:19 ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830191931.GB7311@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=matthewjordannm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.