From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] Feed2maildir: Add python-feedparser
Date: Tue, 30 Aug 2016 15:17:43 -0400
Message-ID: <20160830191743.GA7311@jasmine>
References: <871t1igl1s.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoXo-0008Qq-DS
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:18:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoXk-0001gM-6G
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:18:00 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoXi-0001fN-PU
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:17:56 -0400
Content-Disposition: inline
In-Reply-To: <871t1igl1s.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Matthew Jordan <matthewjordannm@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Aug 21, 2016 at 12:10:23PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 1/2] gnu: Add python-feedparser
> 
> * gnu/packages/python.scm (python-feedparser): New variable.

Thanks for these patches!

> +       (uri (string-append
> +             "https://pypi.python.org/packages/91/d8/7d37fec71ff7c9dbcdd80d2b48bcdd86d6af502156fc93846fb0102cb2c4/feedparser-"
> +             version ".tar.bz2"))

This should use the "pypi-uri" URL system.

> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)))

Does it build without setuptools? If not, setuptools should probably be
a native-input, assuming that setuptools is only used to build.

> +    (synopsis
> +     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")
> +    (description
> +     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")

`guix lint` should have some suggestions for the synopsis and
description. Probably, the synopsis should be something like "Parse Atom
and RSS feeds in Python". And the description should be a complete
sentence.

> +    (license
> +     (non-copyleft "https://github.com/kurtmckee/feedparser/blob/develop/LICENSE"))))

The licenses appear to be bsd-2 or very similar variants of bsd-2.

And, does the software support Python 2? If so, we like to add both
language versions at once.

Can you send an updated patch?