[PATCH] import: cpan: Use tls to query api.metacpan.org.

[PATCH] import: cpan: Use tls to query api.metacpan.org.

[ng0]

[-- Attachment #1: 0001-import-cpan-Use-tls-to-query-api.metacpan.org.patch --]
[-- Type: text/x-patch, Size: 1914 bytes --]

From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Tue, 30 Aug 2016 12:52:51 +0000
Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.

* guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
(cpan-fetch-module)[json-fetch]: Likewise.
---
 guix/import/cpan.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
index 213a155..5d393ac 100644
--- a/guix/import/cpan.scm
+++ b/guix/import/cpan.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
+;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -83,7 +84,7 @@
   "Return the base distribution module for a given module.  E.g. the 'ok'
 module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
 return \"Test-Simple\""
-  (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
+  (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
                                         module))
              "distribution"))
 
@@ -91,7 +92,7 @@ return \"Test-Simple\""
   "Return an alist representation of the CPAN metadata for the perl module MODULE,
 or #f on failure.  MODULE should be e.g. \"Test::Script\""
   ;; This API always returns the latest release of the module.
-  (json-fetch (string-append "http://api.metacpan.org/release/"
+  (json-fetch (string-append "https://api.metacpan.org/release/"
                              ;; XXX: The 'release' api requires the "release"
                              ;; name of the package.  This substitution seems
                              ;; reasonably consistent across packages.
-- 
2.9.3


[-- Attachment #2: Type: text/plain, Size: 70 bytes --]


-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[Eric Bavier]

On Tue, 30 Aug 2016 12:57:47 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Tue, 30 Aug 2016 12:52:51 +0000
> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> 
> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> (cpan-fetch-module)[json-fetch]: Likewise.
> ---
>  guix/import/cpan.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
> index 213a155..5d393ac 100644
> --- a/guix/import/cpan.scm
> +++ b/guix/import/cpan.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>

This patch may be one of those cases, discussed recently on the mailing
list, where a copyright addition is not appropriate.

>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -83,7 +84,7 @@
>    "Return the base distribution module for a given module.  E.g. the 'ok'
>  module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
>  return \"Test-Simple\""
> -  (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
> +  (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
>                                          module))
>               "distribution"))
>  
> @@ -91,7 +92,7 @@ return \"Test-Simple\""
>    "Return an alist representation of the CPAN metadata for the perl module MODULE,
>  or #f on failure.  MODULE should be e.g. \"Test::Script\""
>    ;; This API always returns the latest release of the module.
> -  (json-fetch (string-append "http://api.metacpan.org/release/"
> +  (json-fetch (string-append "https://api.metacpan.org/release/"
>                               ;; XXX: The 'release' api requires the "release"
>                               ;; name of the package.  This substitution seems
>                               ;; reasonably consistent across packages.

Otherwise LGTM,
`~Eric

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[ng0]

Eric Bavier <ericbavier@openmailbox.org> writes:

> On Tue, 30 Aug 2016 12:57:47 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@we.make.ritual.n0.is>
>> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> 
>> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> (cpan-fetch-module)[json-fetch]: Likewise.
>> ---
>>  guix/import/cpan.scm | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> index 213a155..5d393ac 100644
>> --- a/guix/import/cpan.scm
>> +++ b/guix/import/cpan.scm
>> @@ -2,6 +2,7 @@
>>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>>  ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
>> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>
> This patch may be one of those cases, discussed recently on the mailing
> list, where a copyright addition is not appropriate.

"Discussed recently on the mailing list" is one of those occassions
where I'd like to point out that it is a mailing list and therefore is not
very good in giving information unless you search for them.
If there was a conclusion to a longer discussion, please put it into the
contributing section of the manual, otherwise this will be repeated over
and over again, thanks.

I don't necessarily need this copyright addition, so if it looks
otherwise good, can you remove it for mie before commiting the patch, or
do you want me to send it again?

>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -83,7 +84,7 @@
>>    "Return the base distribution module for a given module.  E.g. the 'ok'
>>  module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
>>  return \"Test-Simple\""
>> -  (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
>> +  (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
>>                                          module))
>>               "distribution"))
>>  
>> @@ -91,7 +92,7 @@ return \"Test-Simple\""
>>    "Return an alist representation of the CPAN metadata for the perl module MODULE,
>>  or #f on failure.  MODULE should be e.g. \"Test::Script\""
>>    ;; This API always returns the latest release of the module.
>> -  (json-fetch (string-append "http://api.metacpan.org/release/"
>> +  (json-fetch (string-append "https://api.metacpan.org/release/"
>>                               ;; XXX: The 'release' api requires the "release"
>>                               ;; name of the package.  This substitution seems
>>                               ;; reasonably consistent across packages.
>
> Otherwise LGTM,
> `~Eric

-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[Eric Bavier]

On Tue, 30 Aug 2016 17:16:38 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> Eric Bavier <ericbavier@openmailbox.org> writes:
> 
> > On Tue, 30 Aug 2016 12:57:47 +0000
> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >  
> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> >> 
> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> >> (cpan-fetch-module)[json-fetch]: Likewise.
> >> ---
> >>  guix/import/cpan.scm | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
> >> index 213a155..5d393ac 100644
> >> --- a/guix/import/cpan.scm
> >> +++ b/guix/import/cpan.scm
> >> @@ -2,6 +2,7 @@
> >>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> >>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> >>  ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
> >> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>  
> >
> > This patch may be one of those cases, discussed recently on the mailing
> > list, where a copyright addition is not appropriate.  
> 
> "Discussed recently on the mailing list" is one of those occassions
> where I'd like to point out that it is a mailing list and therefore is not
> very good in giving information unless you search for them.
> If there was a conclusion to a longer discussion, please put it into the
> contributing section of the manual, otherwise this will be repeated over
> and over again, thanks.

It was simply pointed out that the GNU Coding Standards discusses
trivial vs nontrivial code changes.

> I don't necessarily need this copyright addition, so if it looks
> otherwise good, can you remove it for mie before commiting the patch, or
> do you want me to send it again?

I adjust the patch and pushed it in
7a62263ee50c9e2894ea0e746b89f04e3b6484c3.

Thanks,
`~Eric

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[ng0]

Eric Bavier <ericbavier@openmailbox.org> writes:

> On Tue, 30 Aug 2016 17:16:38 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> Eric Bavier <ericbavier@openmailbox.org> writes:
>> 
>> > On Tue, 30 Aug 2016 12:57:47 +0000
>> > ng0 <ng0@we.make.ritual.n0.is> wrote:
>> >  
>> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <ng0@we.make.ritual.n0.is>
>> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> >> 
>> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> >> (cpan-fetch-module)[json-fetch]: Likewise.
>> >> ---
>> >>  guix/import/cpan.scm | 5 +++--
>> >>  1 file changed, 3 insertions(+), 2 deletions(-)
>> >> 
>> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> >> index 213a155..5d393ac 100644
>> >> --- a/guix/import/cpan.scm
>> >> +++ b/guix/import/cpan.scm
>> >> @@ -2,6 +2,7 @@
>> >>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>> >>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>> >>  ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
>> >> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>  
>> >
>> > This patch may be one of those cases, discussed recently on the mailing
>> > list, where a copyright addition is not appropriate.  
>> 
>> "Discussed recently on the mailing list" is one of those occassions
>> where I'd like to point out that it is a mailing list and therefore is not
>> very good in giving information unless you search for them.
>> If there was a conclusion to a longer discussion, please put it into the
>> contributing section of the manual, otherwise this will be repeated over
>> and over again, thanks.
>
> It was simply pointed out that the GNU Coding Standards discusses
> trivial vs nontrivial code changes.

Okay, thanks. I should read more of the coding standards than I already
have.

>> I don't necessarily need this copyright addition, so if it looks
>> otherwise good, can you remove it for mie before commiting the patch, or
>> do you want me to send it again?
>
> I adjust the patch and pushed it in
> 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
>
> Thanks,
> `~Eric

Thanks
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[Ludovic Courtès]

Eric Bavier <ericbavier@openmailbox.org> skribis:

> On Tue, 30 Aug 2016 17:16:38 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> Eric Bavier <ericbavier@openmailbox.org> writes:
>> 
>> > On Tue, 30 Aug 2016 12:57:47 +0000
>> > ng0 <ng0@we.make.ritual.n0.is> wrote:
>> >  
>> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <ng0@we.make.ritual.n0.is>
>> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> >> 
>> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> >> (cpan-fetch-module)[json-fetch]: Likewise.

[...]

> I adjust the patch and pushed it in
> 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.

“make check TESTS=tests/cpan.scm” fails on current master.  Could you
check if this is related?

TIA!  :-)

Ludo’.

Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[Eric Bavier]

On Wed, 31 Aug 2016 16:19:13 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Eric Bavier <ericbavier@openmailbox.org> skribis:
> 
> > On Tue, 30 Aug 2016 17:16:38 +0000
> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >  
> >> Eric Bavier <ericbavier@openmailbox.org> writes:
> >>   
> >> > On Tue, 30 Aug 2016 12:57:47 +0000
> >> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> >> >    
> >> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> >> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
> >> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> >> >> 
> >> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
> >> >> (cpan-fetch-module)[json-fetch]: Likewise.  
> 
> [...]
> 
> > I adjust the patch and pushed it in
> > 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.  
> 
> “make check TESTS=tests/cpan.scm” fails on current master.  Could you
> check if this is related?

Oops.  Fixed in 83ab1a812fc7903abdaabeca2e07bb03f8d25827.

Thanks for catching it.

`~Eric