[PATCH 1/4] gnu: yelp: Update to 3.21.3

[PATCH 1/4] gnu: yelp: Update to 3.21.3

[John Darrington]

From: John Darrington <jmd@gnu.org>

* gnu/packages/gnome.scm (yelp): Update to 3.21.3
---
 gnu/packages/gnome.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index f4488c9..5ea9714 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3711,7 +3711,7 @@ to format Docbook and Mallard documents.")
 (define-public yelp
   (package
     (name "yelp")
-    (version "3.20.1")
+    (version "3.21.3")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -3719,7 +3719,7 @@ to format Docbook and Mallard documents.")
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1hh8yqbv0scn9nksk9mq94cb4sdczlzxplclv2wqr41jmm8v186x"))))
+                "1x8la7qn0l796p4nhprvkwb6sk6yc39xhq3gabvzrhdlb6mjgmrs"))))
     (build-system glib-or-gtk-build-system)
     (native-inputs
      `(("glib:bin" ,glib "bin") ; for glib-genmarshal, etc.
-- 
2.1.4

[PATCH 2/4] CoC: Correct punctuation

[John Darrington]

From: John Darrington <jmd@gnu.org>

* CODE-OF-CONDUCT: "others" is plural. Hence the apostrophe follows
the "s".
---
 CODE-OF-CONDUCT | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CODE-OF-CONDUCT b/CODE-OF-CONDUCT
index 0458fd7..22a0446 100644
--- a/CODE-OF-CONDUCT
+++ b/CODE-OF-CONDUCT
@@ -21,7 +21,7 @@ Examples of unacceptable behavior by participants include:
 * Personal attacks
 * Trolling or insulting/derogatory comments
 * Public or private harassment
-* Publishing other's private information, such as physical or electronic
+* Publishing others' private information, such as physical or electronic
 addresses, without explicit permission
 * Other unethical or unprofessional conduct
 
-- 
2.1.4

Re: [PATCH 2/4] CoC: Correct punctuation

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

On Sat, Aug 27, 2016 at 08:19:37PM +0200, John Darrington wrote:
> From: John Darrington <jmd@gnu.org>
> 
> * CODE-OF-CONDUCT: "others" is plural. Hence the apostrophe follows
> the "s".
> ---
>  CODE-OF-CONDUCT | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CODE-OF-CONDUCT b/CODE-OF-CONDUCT
> index 0458fd7..22a0446 100644
> --- a/CODE-OF-CONDUCT
> +++ b/CODE-OF-CONDUCT
> @@ -21,7 +21,7 @@ Examples of unacceptable behavior by participants include:
>  * Personal attacks
>  * Trolling or insulting/derogatory comments
>  * Public or private harassment
> -* Publishing other's private information, such as physical or electronic
> +* Publishing others' private information, such as physical or electronic
>  addresses, without explicit permission
>  * Other unethical or unprofessional conduct
>  
> -- 
> 2.1.4
> 

This Code of Conduct is adapted from the Contributor Covenant
(http://contributor-covenant.org), version 1.3.0, available at
http://contributor-covenant.org/version/1/3/0/

I would rather see what they have to saw about it upstream.
...actually, upstream has "other's"

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/4] CoC: Correct punctuation

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

On Sun, Aug 28, 2016 at 12:19:15PM +0300, Efraim Flashner wrote:
     On Sat, Aug 27, 2016 at 08:19:37PM +0200, John Darrington wrote:
     > +++ b/CODE-OF-CONDUCT
     > @@ -21,7 +21,7 @@ Examples of unacceptable behavior by participants include:
     >  * Personal attacks
     >  * Trolling or insulting/derogatory comments
     >  * Public or private harassment
     > -* Publishing other's private information, such as physical or electronic
     > +* Publishing others' private information, such as physical or electronic
     >  addresses, without explicit permission
     >  * Other unethical or unprofessional conduct
     
     This Code of Conduct is adapted from the Contributor Covenant
     (http://contributor-covenant.org), version 1.3.0, available at
     http://contributor-covenant.org/version/1/3/0/
     
     I would rather see what they have to saw about it upstream.
     ...actually, upstream has "other's"

"other's" would imply that publishing one person's details is unacceptable,
but publishing many persons' is ok.  Whereas, "others'" means that publishing
anybody's details is unacceptable.

See http://queens-english-society.org/qes-useful-guides-to-english/punctuation

J'


-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH 2/4] CoC: Correct punctuation

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

On Sun, Aug 28, 2016 at 11:52:52AM +0200, John Darrington wrote:
> On Sun, Aug 28, 2016 at 12:19:15PM +0300, Efraim Flashner wrote:
>      On Sat, Aug 27, 2016 at 08:19:37PM +0200, John Darrington wrote:
>      > +++ b/CODE-OF-CONDUCT
>      > @@ -21,7 +21,7 @@ Examples of unacceptable behavior by participants include:
>      >  * Personal attacks
>      >  * Trolling or insulting/derogatory comments
>      >  * Public or private harassment
>      > -* Publishing other's private information, such as physical or electronic
>      > +* Publishing others' private information, such as physical or electronic
>      >  addresses, without explicit permission
>      >  * Other unethical or unprofessional conduct
>      
>      This Code of Conduct is adapted from the Contributor Covenant
>      (http://contributor-covenant.org), version 1.3.0, available at
>      http://contributor-covenant.org/version/1/3/0/
>      
>      I would rather see what they have to saw about it upstream.
>      ...actually, upstream has "other's"
> 
> "other's" would imply that publishing one person's details is unacceptable,
> but publishing many persons' is ok.  Whereas, "others'" means that publishing
> anybody's details is unacceptable.

The current wording is, at best, awkward. But, I think this patch should
be sent upstream so all adopters of the Contributor Covenant can benefit
from the clarification.

https://github.com/ContributorCovenant/contributor_covenant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH 3/4] gnu: Add German Aspell dictionary.

[John Darrington]

From: John Darrington <jmd@gnu.org>

* gnu/packages/aspell.scm (aspell-dict-de): New variable.
---
 gnu/packages/aspell.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 117cd33..f836819 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -97,6 +97,13 @@ dictionaries, including personal ones.")
     (home-page "http://aspell.net/")))
 
 
+(define-public aspell-dict-de
+  (aspell-dictionary "de" "German"
+                     #:version "20030222-1"
+                     #:sha256
+                     (base32
+                      "01p92qj66cqb346gk7hjfynaap5sbcn85xz07kjfdq623ghr8v5s")))
+
 (define-public aspell-dict-en
   (aspell-dictionary "en" "English"
                      #:version "2016.01.19-0"
-- 
2.1.4

Re: [PATCH 3/4] gnu: Add German Aspell dictionary.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Sat, Aug 27, 2016 at 08:19:38PM +0200, John Darrington wrote:
> From: John Darrington <jmd@gnu.org>
> 
> * gnu/packages/aspell.scm (aspell-dict-de): New variable.
> ---
>  gnu/packages/aspell.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
> index 117cd33..f836819 100644
> --- a/gnu/packages/aspell.scm
> +++ b/gnu/packages/aspell.scm
> @@ -97,6 +97,13 @@ dictionaries, including personal ones.")
>      (home-page "http://aspell.net/")))
>  
>  
> +(define-public aspell-dict-de
> +  (aspell-dictionary "de" "German"
> +                     #:version "20030222-1"
> +                     #:sha256
> +                     (base32
> +                      "01p92qj66cqb346gk7hjfynaap5sbcn85xz07kjfdq623ghr8v5s")))
> +
>  (define-public aspell-dict-en
>    (aspell-dictionary "en" "English"
>                       #:version "2016.01.19-0"
> -- 
> 2.1.4
> 
> 

don't forget your copyright line. Otherwise looks good.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 3/4] gnu: Add German Aspell dictionary.

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

On Sun, Aug 28, 2016 at 12:20:45PM +0300, Efraim Flashner wrote:
     > +(define-public aspell-dict-de
     > +  (aspell-dictionary "de" "German"
     > +                     #:version "20030222-1"
     > +                     #:sha256
     > +                     (base32
     > +                      "01p92qj66cqb346gk7hjfynaap5sbcn85xz07kjfdq623ghr8v5s")))
     don't forget your copyright line. Otherwise looks good.
     
I didn't forget.  But I don't consider these 6 lines to be in any respect
novel, creative or original.  The FSF guidelines for what is regarded as
"legally significant" for copyright purposes mentions the limit of 15 lines.

In fact, I challenge anyone to offer a definition of aspell-dict-de which
works in Guix AND satisfies our rather strict coding style, and does not
differ from the above, except in whitespace.

In other words, there is nothing novel or creative in what I have written.
Thus, is would be dishonest (perhaps illegal?) for me to claim copyright on
this work.

J'

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH 3/4] gnu: Add German Aspell dictionary.

[Alex Kost]

John Darrington (2016-08-28 15:41 +0300) wrote:

> On Sun, Aug 28, 2016 at 12:20:45PM +0300, Efraim Flashner wrote:
>      > +(define-public aspell-dict-de
>      > +  (aspell-dictionary "de" "German"
>      > +                     #:version "20030222-1"
>      > +                     #:sha256
>      > +                     (base32
>      > +                      "01p92qj66cqb346gk7hjfynaap5sbcn85xz07kjfdq623ghr8v5s")))
>      don't forget your copyright line. Otherwise looks good.
>
> I didn't forget.  But I don't consider these 6 lines to be in any respect
> novel, creative or original.  The FSF guidelines for what is regarded as
> "legally significant" for copyright purposes mentions the limit of 15 lines.
>
> In fact, I challenge anyone to offer a definition of aspell-dict-de which
> works in Guix AND satisfies our rather strict coding style, and does not
> differ from the above, except in whitespace.
>
> In other words, there is nothing novel or creative in what I have written.
> Thus, is would be dishonest (perhaps illegal?) for me to claim copyright on
> this work.

I think this patch deserves it.  My understanding is we just don't have
a policy on adding copyright lines: some people add a copyright line
even for a simple package update.

-- 
Alex

Re: [PATCH 3/4] gnu: Add German Aspell dictionary.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> John Darrington (2016-08-28 15:41 +0300) wrote:
>
>> On Sun, Aug 28, 2016 at 12:20:45PM +0300, Efraim Flashner wrote:
>>      > +(define-public aspell-dict-de
>>      > +  (aspell-dictionary "de" "German"
>>      > +                     #:version "20030222-1"
>>      > +                     #:sha256
>>      > +                     (base32
>>      > +                      "01p92qj66cqb346gk7hjfynaap5sbcn85xz07kjfdq623ghr8v5s")))
>>      don't forget your copyright line. Otherwise looks good.
>>
>> I didn't forget.  But I don't consider these 6 lines to be in any respect
>> novel, creative or original.  The FSF guidelines for what is regarded as
>> "legally significant" for copyright purposes mentions the limit of 15 lines.
>>
>> In fact, I challenge anyone to offer a definition of aspell-dict-de which
>> works in Guix AND satisfies our rather strict coding style, and does not
>> differ from the above, except in whitespace.
>>
>> In other words, there is nothing novel or creative in what I have written.
>> Thus, is would be dishonest (perhaps illegal?) for me to claim copyright on
>> this work.
>
> I think this patch deserves it.  My understanding is we just don't have
> a policy on adding copyright lines: some people add a copyright line
> even for a simple package update.

John is right; simple package updates are not legally significant
either.  But then I think “too many” copyright lines is better than not
enough, and it’s not worth bothering.

Ludo’.

[PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

[John Darrington]

From: John Darrington <jmd@gnu.org>

* gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
configure flag.
[inputs]: Add mit-krb5
---
 gnu/packages/onc-rpc.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
index d9b2f9d..d5858e8 100644
--- a/gnu/packages/onc-rpc.scm
+++ b/gnu/packages/onc-rpc.scm
@@ -20,6 +20,7 @@
   #:use-module (guix licenses)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (gnu packages mit-krb5)
   #:use-module (guix build-system gnu))
 
 (define-public libtirpc
@@ -36,16 +37,14 @@
                 "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     (build-system gnu-build-system)
     (arguments
-     '(;; Doesn't work with GNU GSS.
-       #:configure-flags '("--disable-gssapi")
-
-       #:phases (alist-cons-after
+     '(#:phases (alist-cons-after
                  'unpack 'remote-dangling-symlink
                  (lambda _
                    ;; Remote the dangling symlinks since it breaks the
                    ;; 'patch-source-shebangs' file tree traversal.
                    (delete-file "INSTALL"))
                  %standard-phases)))
+    (inputs `(("mit-krb5" ,mit-krb5)))
     (home-page "http://sourceforge.net/projects/libtirpc/")
     (synopsis "Transport-independent Sun/ONC RPC implementation")
     (description
-- 
2.1.4

Re: [PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
> From: John Darrington <jmd@gnu.org>
> 
> * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
> configure flag.
> [inputs]: Add mit-krb5
> ---
>  gnu/packages/onc-rpc.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
> index d9b2f9d..d5858e8 100644
> --- a/gnu/packages/onc-rpc.scm
> +++ b/gnu/packages/onc-rpc.scm
> @@ -20,6 +20,7 @@
>    #:use-module (guix licenses)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> +  #:use-module (gnu packages mit-krb5)
>    #:use-module (guix build-system gnu))
>  
>  (define-public libtirpc
> @@ -36,16 +37,14 @@
>                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(;; Doesn't work with GNU GSS.
> -       #:configure-flags '("--disable-gssapi")
> -
> -       #:phases (alist-cons-after
> +     '(#:phases (alist-cons-after
>                   'unpack 'remote-dangling-symlink
>                   (lambda _
>                     ;; Remote the dangling symlinks since it breaks the
>                     ;; 'patch-source-shebangs' file tree traversal.
>                     (delete-file "INSTALL"))
>                   %standard-phases)))
> +    (inputs `(("mit-krb5" ,mit-krb5)))
>      (home-page "http://sourceforge.net/projects/libtirpc/")
>      (synopsis "Transport-independent Sun/ONC RPC implementation")
>      (description
> -- 
> 2.1.4
> 

Has the issue with GNU GSS been fixed? Also, this would be a good time
to switch to modify-phases while you're already touching the package.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 2525 bytes --]

On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
     On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
     > From: John Darrington <jmd@gnu.org>
     > 
     > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
     > configure flag.
     > [inputs]: Add mit-krb5
     > ---
     >  gnu/packages/onc-rpc.scm | 7 +++----
     >  1 file changed, 3 insertions(+), 4 deletions(-)
     > 
     > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
     > index d9b2f9d..d5858e8 100644
     > --- a/gnu/packages/onc-rpc.scm
     > +++ b/gnu/packages/onc-rpc.scm
     > @@ -20,6 +20,7 @@
     >    #:use-module (guix licenses)
     >    #:use-module (guix packages)
     >    #:use-module (guix download)
     > +  #:use-module (gnu packages mit-krb5)
     >    #:use-module (guix build-system gnu))
     >  
     >  (define-public libtirpc
     > @@ -36,16 +37,14 @@
     >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     >      (build-system gnu-build-system)
     >      (arguments
     > -     '(;; Doesn't work with GNU GSS.
     > -       #:configure-flags '("--disable-gssapi")
     > -
     > -       #:phases (alist-cons-after
     > +     '(#:phases (alist-cons-after
     >                   'unpack 'remote-dangling-symlink
     >                   (lambda _
     >                     ;; Remote the dangling symlinks since it breaks the
     >                     ;; 'patch-source-shebangs' file tree traversal.
     >                     (delete-file "INSTALL"))
     >                   %standard-phases)))
     > +    (inputs `(("mit-krb5" ,mit-krb5)))
     >      (home-page "http://sourceforge.net/projects/libtirpc/")
     >      (synopsis "Transport-independent Sun/ONC RPC implementation")
     >      (description
     > -- 
     > 2.1.4
     > 
     
     Has the issue with GNU GSS been fixed? Also, this would be a good time
     to switch to modify-phases while you're already touching the package.

I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
an input to this package.  I don't think there is any connection.

I'll have a look to see if modify-phases makes things simpler.

J'
     
-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
>      On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
>      > From: John Darrington <jmd@gnu.org>
>      > 
>      > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
>      > configure flag.
>      > [inputs]: Add mit-krb5
>      > ---
>      >  gnu/packages/onc-rpc.scm | 7 +++----
>      >  1 file changed, 3 insertions(+), 4 deletions(-)
>      > 
>      > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
>      > index d9b2f9d..d5858e8 100644
>      > --- a/gnu/packages/onc-rpc.scm
>      > +++ b/gnu/packages/onc-rpc.scm
>      > @@ -20,6 +20,7 @@
>      >    #:use-module (guix licenses)
>      >    #:use-module (guix packages)
>      >    #:use-module (guix download)
>      > +  #:use-module (gnu packages mit-krb5)
>      >    #:use-module (guix build-system gnu))
>      >  
>      >  (define-public libtirpc
>      > @@ -36,16 +37,14 @@
>      >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
>      >      (build-system gnu-build-system)
>      >      (arguments
>      > -     '(;; Doesn't work with GNU GSS.
>      > -       #:configure-flags '("--disable-gssapi")
>      > -
>      > -       #:phases (alist-cons-after
>      > +     '(#:phases (alist-cons-after
>      >                   'unpack 'remote-dangling-symlink
>      >                   (lambda _
>      >                     ;; Remote the dangling symlinks since it breaks the
>      >                     ;; 'patch-source-shebangs' file tree traversal.
>      >                     (delete-file "INSTALL"))
>      >                   %standard-phases)))
>      > +    (inputs `(("mit-krb5" ,mit-krb5)))
>      >      (home-page "http://sourceforge.net/projects/libtirpc/")
>      >      (synopsis "Transport-independent Sun/ONC RPC implementation")
>      >      (description
>      > -- 
>      > 2.1.4
>      > 
>      
>      Has the issue with GNU GSS been fixed? Also, this would be a good time
>      to switch to modify-phases while you're already touching the package.
>
> I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
> an input to this package.  I don't think there is any connection.

It’s preferable to use GNU GSS rather than mit-krb5 if that’s possible,
which maybe it isn’t.

> I'll have a look to see if modify-phases makes things simpler.

Regardless, the patch LGTM.

Thanks,
Ludo’.

Re: [PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

On Mon, Aug 29, 2016 at 06:52:41PM +0200, Ludovic Court??s wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
     >      On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
     >      > From: John Darrington <jmd@gnu.org>
     >      > 
     >      > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
     >      > configure flag.
     >      > [inputs]: Add mit-krb5
     >      > ---
     >      >  gnu/packages/onc-rpc.scm | 7 +++----
     >      >  1 file changed, 3 insertions(+), 4 deletions(-)
     >      > 
     >      > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
     >      > index d9b2f9d..d5858e8 100644
     >      > --- a/gnu/packages/onc-rpc.scm
     >      > +++ b/gnu/packages/onc-rpc.scm
     >      > @@ -20,6 +20,7 @@
     >      >    #:use-module (guix licenses)
     >      >    #:use-module (guix packages)
     >      >    #:use-module (guix download)
     >      > +  #:use-module (gnu packages mit-krb5)
     >      >    #:use-module (guix build-system gnu))
     >      >  
     >      >  (define-public libtirpc
     >      > @@ -36,16 +37,14 @@
     >      >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     >      >      (build-system gnu-build-system)
     >      >      (arguments
     >      > -     '(;; Doesn't work with GNU GSS.
     >      > -       #:configure-flags '("--disable-gssapi")
     >      > -
     >      > -       #:phases (alist-cons-after
     >      > +     '(#:phases (alist-cons-after
     >      >                   'unpack 'remote-dangling-symlink
     >      >                   (lambda _
     >      >                     ;; Remote the dangling symlinks since it breaks the
     >      >                     ;; 'patch-source-shebangs' file tree traversal.
     >      >                     (delete-file "INSTALL"))
     >      >                   %standard-phases)))
     >      > +    (inputs `(("mit-krb5" ,mit-krb5)))
     >      >      (home-page "http://sourceforge.net/projects/libtirpc/")
     >      >      (synopsis "Transport-independent Sun/ONC RPC implementation")
     >      >      (description
     >      > -- 
     >      > 2.1.4
     >      > 
     >      
     >      Has the issue with GNU GSS been fixed? Also, this would be a good time
     >      to switch to modify-phases while you're already touching the package.
     >
     > I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
     > an input to this package.  I don't think there is any connection.
     
     It???s preferable to use GNU GSS rather than mit-krb5 if that???s possible,
     which maybe it isn???t.

I don't think it is possible, for the simple reason that this is not what 
GSS is intended to do.  If however it transpires that GNU GSS does somehow
eventually do it, the  we can change it then.

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH 1/4] gnu: yelp: Update to 3.21.3

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> From: John Darrington <jmd@gnu.org>
>
> * gnu/packages/gnome.scm (yelp): Update to 3.21.3

My understanding is that odd minor version numbers denote development
releases, no?  In that case we should wait for 3.22.x.

Ludo’.

Re: [PATCH 1/4] gnu: yelp: Update to 3.21.3

[John Darrington]

On Fri, Sep 02, 2016 at 03:16:25PM +0200, Ludovic Court??s wrote:
> John Darrington <john@darrington.wattle.id.au> skribis:
> 
> > From: John Darrington <jmd@gnu.org>
> >
> > * gnu/packages/gnome.scm (yelp): Update to 3.21.3
> 
> My understanding is that odd minor version numbers denote development
> releases, no?  In that case we should wait for 3.22.x.
> 
I didn't know that gnome did and it was downloaded from the canonical gnome distribution site.
I checked all the READMEs there and I don't see any mention of such a policy.

But feel free to revert if you think appropriate.

J'

Re: [PATCH 1/4] gnu: yelp: Update to 3.21.3

[Ludovic Courtès]

John Darrington <jmd@gnu.org> skribis:

> On Fri, Sep 02, 2016 at 03:16:25PM +0200, Ludovic Court??s wrote:
>> John Darrington <john@darrington.wattle.id.au> skribis:
>> 
>> > From: John Darrington <jmd@gnu.org>
>> >
>> > * gnu/packages/gnome.scm (yelp): Update to 3.21.3
>> 
>> My understanding is that odd minor version numbers denote development
>> releases, no?  In that case we should wait for 3.22.x.
>> 
> I didn't know that gnome did and it was downloaded from the canonical gnome distribution site.
> I checked all the READMEs there and I don't see any mention of such a policy.

See <https://www.gnome.org/gnome-3/source/>.  This is why ‘guix refresh
-t gnome’ won’t upgrade to odd minor numbers; see (guix
gnu-maintenance).

> But feel free to revert if you think appropriate.

I’ll let you do it if you don’t mind.  :-)

Thanks,
Ludo’.

Re: [PATCH 1/4] gnu: yelp: Update to 3.21.3

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Sat, Sep 03, 2016 at 03:57:19PM +0200, Ludovic Court??s wrote:
     John Darrington <jmd@gnu.org> skribis:
     
     > On Fri, Sep 02, 2016 at 03:16:25PM +0200, Ludovic Court??s wrote:
     >> John Darrington <john@darrington.wattle.id.au> skribis:
     >> 
     >> > From: John Darrington <jmd@gnu.org>
     >> >
     >> > * gnu/packages/gnome.scm (yelp): Update to 3.21.3
     >> 
     >> My understanding is that odd minor version numbers denote development
     >> releases, no?  In that case we should wait for 3.22.x.
     >> 
     > I didn't know that gnome did and it was downloaded from the canonical gnome distribution site.
     > I checked all the READMEs there and I don't see any mention of such a policy.
     
     See <https://www.gnome.org/gnome-3/source/>.  This is why ???guix refresh
     -t gnome??? won???t upgrade to odd minor numbers; see (guix
     gnu-maintenance).
     
     > But feel free to revert if you think appropriate.
     
     I???ll let you do it if you don???t mind.  :-)

Done.

J'

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]