From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [PATCH] Fix compiling on CentOS 7. Date: Sat, 27 Aug 2016 08:57:56 +0200 Message-ID: <20160827065756.kblwxq3gmg63eug2@venom> References: <87d1kvpazv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ck34ck577gq4ydm5" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdXZ6-0004Ki-Kg for guix-devel@gnu.org; Sat, 27 Aug 2016 02:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdXZ1-0007NY-Mq for guix-devel@gnu.org; Sat, 27 Aug 2016 02:58:04 -0400 Content-Disposition: inline In-Reply-To: <87d1kvpazv.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org --ck34ck577gq4ydm5 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Fri, Aug 26, 2016 at 09:48:36PM +0200, Roel Janssen wrote: >Dear Guix, > >Due to an old Automake version (1.13), running the `./configure' phase on >CentOS 7 fails with: > >> autoreconf: running: automake --add-missing --copy --force-missing >> configure.ac:21: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. >> configure.ac:21: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, >> configure.ac:21: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. >> Makefile.am:422: warning: AM_GNU_GETTEXT used but 'po' not in SUBDIRS >> automake: error: cannot open < ./%D%/guix.texi: No such file or directory >> autoreconf: automake failed with exit status: 1 > >(It does not replace %D% with the appropriate directory..) > >The attached patch replaces each instance of %D%, which I believe stands >for the current subdirectory from the project root, with the appropriate >directory. With these changes, I've been able to compile GNU Guix on >CentOS 7. > >I am not sure how this change impacts custom configure options, so I >would like to ask someone with more Automake knowledge and experience to >elaborate on the possible downsides of applying this patch. > >If this change is acceptable to the project, I will update the commit >message to a more detailed and conforming message. Suggestions are >welcome here though. > >What do you think about making Guix compilable on this "stable" >distribution? :-) I'd prefer to keep this patch in CentOS (or similar distribution with outdated software) as distro specific. I can assume that CentOS 8 won't need it and you can just drop it for newer releases. Best regards, S_W --ck34ck577gq4ydm5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXwTncAAoJEEoj40+gM0NtH3MP/RmtxPjqt01mUOXW2W/XCIZh K9pxPHx859l/qFMYCKu6RFgFNtoADbXZnHxL85FctoLpHi7QEgHU4CWKQydgMwMZ hFmNTRmwDDFZCDNlIaPTMIwOUjFfRXad8Yyo1edg/w17Fdr0bysQSOslFyGpIdYF bDDJx7ssi0mher79ZAOTsKkIaB5p9MxQN5vW+xh7KDSIHKw0wb1wUYt9wXG9Qwjy 5DcSExKG2ft22BK0e137plOAY9YXmZlnuOyiIfmEW2Qw5t87gDIEtvlgwHP7OrFy kX8spBJsezF6b22VSx2JeKsKn2jHmck7m7jzUJiVhLJaWcxvUxSiZXPCI/TXi/DM yvvrf2YmlihgqJpt+FxukteZr6h0tm0kt2DcG3FCD3nIWRvgvxCp2Z2tjHp3+pDI CD2tyJmVjGzM9Wcq4oavKXbzjIZf+ARmlo4e4f37Ih4k5hihaB7jJOe1QUKldDRX B63uxCIQzpfmEUvFXx5uNXDGfMOLeZg41KAMRR5eCLZ28wYix1fCz5b7/CI40Z+g XXtxLGVKTt/kE55OynBiElM+nnAW2z8/payPmdd1MlmFm95SA0c91PpHHPgDu8AD 4elnAZCCIARsGFJrrkLg84ysOAyhpV9g0/VGKF/As8U/xPCPs78IwEuW6++Kcnup BFhom2RkZr/r12VX72rJ =a9uC -----END PGP SIGNATURE----- --ck34ck577gq4ydm5--