From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/4] gnu: Add steghide.
Date: Tue, 23 Aug 2016 19:53:24 -0400
Message-ID: <20160823235324.GC24374@jasmine>
References: <20160823061512.13024-1-ericbavier@openmailbox.org>
	<20160823061512.13024-2-ericbavier@openmailbox.org>
	<20160823201611.GB22647@jasmine>
	<20160823171949.645525f2@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcLVi-00048R-UT
	for guix-devel@gnu.org; Tue, 23 Aug 2016 19:53:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcLVe-0001cQ-SU
	for guix-devel@gnu.org; Tue, 23 Aug 2016 19:53:37 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcLVd-0001Xy-LK
	for guix-devel@gnu.org; Tue, 23 Aug 2016 19:53:34 -0400
Content-Disposition: inline
In-Reply-To: <20160823171949.645525f2@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, Aug 23, 2016 at 05:19:49PM -0500, Eric Bavier wrote:
> On Tue, 23 Aug 2016 16:16:11 -0400
> Leo Famulari <leo@famulari.name> wrote:
> > My understanding is that '-fpermissive' downgrades some compiler errors
> > to warnings. Is that correct?
> 
> Correct.  Specifically, this is to avoid:
> 
> MHashPP.cc:123:38: error: invalid conversion from ‘uint8_t* {aka unsigned char*}’ to ‘char*’ [-fpermissive]
> 
> which I'm not comfortable developing a better fix for.

Okay. Can you mention that specific error in a code comment? It seems
like valuable information to me.

> 
> > 
> > > diff --git a/gnu/packages/patches/steghide-fixes.patch b/gnu/packages/patches/steghide-fixes.patch  
> > 
> > I don't understand what this patch does (I don't know any C++). Can you
> > add some comments explaining it? Should we try to get the upstream
> > maintainers to apply it?  
> 
> This patch fixes an "undefined ULONG_MAX" error and "specializing
> member ‘...’ requires ‘template<>’ syntax" errors.
> 
> Upstream appears to currently be in limbo, but I just sent the patch to
> the mailing list.

Okay, maybe wait a couple days in case they respond?