From: Leo Famulari <leo@famulari.name>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/4] gnu: Add Tomb.
Date: Tue, 23 Aug 2016 19:50:35 -0400 [thread overview]
Message-ID: <20160823235035.GB24374@jasmine> (raw)
In-Reply-To: <20160823174127.46a77d57@openmailbox.org>
On Tue, Aug 23, 2016 at 05:41:27PM -0500, Eric Bavier wrote:
> On Tue, 23 Aug 2016 16:50:59 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
> > On Tue, Aug 23, 2016 at 01:15:12AM -0500, Eric Bavier wrote:
> > > + (inputs ;users should install their preferred pinentry-*
> > > + `(("zsh" ,zsh)
> >
> > Does it really need the zsh shell?
>
> Yes, "bin/tomb" is a Zsh script.
Wow, interesting. I will read it (not as part of patch review).
>
> >
> > > + #:tests? #f ;requires root
> >
> > Too bad :/ A program like this should be tested.
>
> I've tested most functionality manually. But there is no way to get
> root in the build environment. There may be some sanity tests that
> could be performed in a custom 'check phase, checks that don't need
> root.
Yes, there may be. I don't think it's a blocker, however.
next prev parent reply other threads:[~2016-08-23 23:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:15 [PATCH 1/4] gnu: Add mlocate Eric Bavier
2016-08-23 6:15 ` [PATCH 2/4] gnu: Add steghide Eric Bavier
2016-08-23 20:16 ` Leo Famulari
2016-08-23 22:19 ` Eric Bavier
2016-08-23 23:53 ` Leo Famulari
2016-08-23 6:15 ` [PATCH 3/4] gnu: Add Swish-e Eric Bavier
2016-08-23 6:27 ` Leo Famulari
2016-08-23 6:49 ` Eric Bavier
2016-08-23 20:46 ` Leo Famulari
2016-08-23 22:34 ` Eric Bavier
2016-08-23 6:15 ` [PATCH 4/4] gnu: Add Tomb Eric Bavier
2016-08-23 20:50 ` Leo Famulari
2016-08-23 22:41 ` Eric Bavier
2016-08-23 23:50 ` Leo Famulari [this message]
2016-08-23 20:12 ` [PATCH 1/4] gnu: Add mlocate Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823235035.GB24374@jasmine \
--to=leo@famulari.name \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.