From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/4] gnu: Add steghide.
Date: Tue, 23 Aug 2016 16:16:11 -0400
Message-ID: <20160823201611.GB22647@jasmine>
References: <20160823061512.13024-1-ericbavier@openmailbox.org>
	<20160823061512.13024-2-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57778)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcI7W-0006HE-KO
	for guix-devel@gnu.org; Tue, 23 Aug 2016 16:16:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcI7S-0007FQ-9k
	for guix-devel@gnu.org; Tue, 23 Aug 2016 16:16:25 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bcI7R-0007E4-3a
	for guix-devel@gnu.org; Tue, 23 Aug 2016 16:16:22 -0400
Content-Disposition: inline
In-Reply-To: <20160823061512.13024-2-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, Aug 23, 2016 at 01:15:10AM -0500, Eric Bavier wrote:
> * gnu/packages/image.scm (steghide): New variable.
> * gnu/packages/patches/steghide-fixes.patch: New patch.
> * gnu/local.mk (dist_patch_DATA): Add it.

> +    (arguments
> +     `(#:make-flags '("CXXFLAGS=-fpermissive"))) ;required for MHashPP.cc

My understanding is that '-fpermissive' downgrades some compiler errors
to warnings. Is that correct?

> diff --git a/gnu/packages/patches/steghide-fixes.patch b/gnu/packages/patches/steghide-fixes.patch

I don't understand what this patch does (I don't know any C++). Can you
add some comments explaining it? Should we try to get the upstream
maintainers to apply it?