From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 2/4] gnu: Add steghide.
Date: Tue, 23 Aug 2016 17:19:49 -0500
Message-ID: <20160823171949.645525f2@openmailbox.org>
References: <20160823061512.13024-1-ericbavier@openmailbox.org>
	<20160823061512.13024-2-ericbavier@openmailbox.org>
	<20160823201611.GB22647@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bcK38-0006Cg-Is
	for guix-devel@gnu.org; Tue, 23 Aug 2016 18:20:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bcK33-0001EJ-Pw
	for guix-devel@gnu.org; Tue, 23 Aug 2016 18:20:01 -0400
Received: from mail.openmailbox.org ([62.4.1.34]:55763)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bcK33-0001EE-G7
	for guix-devel@gnu.org; Tue, 23 Aug 2016 18:19:57 -0400
In-Reply-To: <20160823201611.GB22647@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

On Tue, 23 Aug 2016 16:16:11 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Tue, Aug 23, 2016 at 01:15:10AM -0500, Eric Bavier wrote:
> > * gnu/packages/image.scm (steghide): New variable.
> > * gnu/packages/patches/steghide-fixes.patch: New patch.
> > * gnu/local.mk (dist_patch_DATA): Add it. =20
>=20
> > +    (arguments
> > +     `(#:make-flags '("CXXFLAGS=3D-fpermissive"))) ;required for MHash=
PP.cc =20
>=20
> My understanding is that '-fpermissive' downgrades some compiler errors
> to warnings. Is that correct?

Correct.  Specifically, this is to avoid:

MHashPP.cc:123:38: error: invalid conversion from =E2=80=98uint8_t* {aka un=
signed char*}=E2=80=99 to =E2=80=98char*=E2=80=99 [-fpermissive]

which I'm not comfortable developing a better fix for.

>=20
> > diff --git a/gnu/packages/patches/steghide-fixes.patch b/gnu/packages/p=
atches/steghide-fixes.patch =20
>=20
> I don't understand what this patch does (I don't know any C++). Can you
> add some comments explaining it? Should we try to get the upstream
> maintainers to apply it? =20

This patch fixes an "undefined ULONG_MAX" error and "specializing
member =E2=80=98...=E2=80=99 requires =E2=80=98template<>=E2=80=99 syntax" =
errors.

Upstream appears to currently be in limbo, but I just sent the patch to
the mailing list.

`~Eric