From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH v6] gnu: Add u-boot, device-tree-compiler. Date: Mon, 22 Aug 2016 21:40:54 +0200 Message-ID: <20160822214054.65959933@scratchpost.org> References: <20160801200535.30747-1-dannym@scratchpost.org> <20160802071139.6664-1-dannym@scratchpost.org> <20160821102347.3ffb2103@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbv6L-0000n0-P1 for guix-devel@gnu.org; Mon, 22 Aug 2016 15:41:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbv6H-0000dL-L3 for guix-devel@gnu.org; Mon, 22 Aug 2016 15:41:41 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:49737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbv6H-0000dH-EO for guix-devel@gnu.org; Mon, 22 Aug 2016 15:41:37 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel On Sun, 21 Aug 2016 11:47:10 +0200 David Craven wrote: > Is this necessary? > > + #:make-flags '("HOSTCC=gcc") Yes. When you remove it you get: starting phase `configure' configs/efi-x86_defconfig HOSTCC scripts/basic/fixdep /gnu/store/03zjklzb1jr6v9p4zpy5c0p9k6h1c54y-bash-4.3.42/bin/bash: cc: command not found scripts/Makefile.host:94: recipe for target 'scripts/basic/fixdep' failed That's because it needs to compile some native helpers even when (potentially) cross compiling. If there are better ways to find out what the appropriate compiler is, I'm all for it. > this line also seems weird to me, why does the device-tree-compiler > respect HOME instead of PREFIX? > > + `(#:make-flags `("CC=gcc" ,(string-append "HOME=" (assoc-ref > %outputs "out"))) ; Note: or patch out PREFIX I don't know. You have to ask them... The culprit is: Makefile: PREFIX = $(HOME) <---- here BINDIR = $(PREFIX)/bin LIBDIR = $(PREFIX)/lib INCLUDEDIR = $(PREFIX)/include I know I could patch this out but I don't feel like having fragile patches (what if the context changes) or substitutions (what if it is changed to use some other way to cause PREFIX to be set to HOME) when I can just set HOME up and that's it. > I thought we were phasing #:select for licenses out? > > + #:use-module ((guix licenses) #:select (gpl2)) Yes, indeed. When someone applies this patch please take this into account. > I think that we should add shortcuts for uboot loaders that would work > with our supported platforms in qemu. For arm-system-qemu that would > be the versatile-express board that works out of the box, Which u-boot defconfig should we use? List of defconfigs with "vexpress" in the name: vexpress_aemv8a_dram_defconfig vexpress_aemv8a_juno_defconfig vexpress_aemv8a_semi_defconfig vexpress_ca15_tc2_defconfig vexpress_ca5x2_defconfig vexpress_ca9x4_defconfig > I don't know > what the equivalent is for x86_64 and mips. (The rationale being that > the goal is to get guix system vm --system=armhf-linux working) I don't know either... For simple compilation tests (i.e. whether I broke the package specification) I use u-boot-efi-x86 on x86_64 without cross compiling. Not sure what the status of qemu is in that regard. Can it do UEFI?