From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-odfpy.
Date: Sun, 21 Aug 2016 16:13:56 -0400
Message-ID: <20160821201356.GB18423@jasmine>
References: <878tvvz69g.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbZ8F-0005Z5-0D
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:14:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbZ8A-0006Yc-Tr
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:14:10 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbZ89-0006Y1-NL
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:14:06 -0400
Content-Disposition: inline
In-Reply-To: <878tvvz69g.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

On Wed, Aug 17, 2016 at 05:53:31PM +0100, Marius Bakke wrote:
> Subject: [PATCH] gnu: Add python-odfpy.
> 
> * gnu/packages/python.scm (python-odfpy, python2-odfpy): New variables.

Thanks for the patch!

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _ (zero? (system* "make" "-C" "tests")))))))
> +    (native-inputs
> +     ;; The test runner wants to check both python versions at once.
> +     ;; To avoid patching it, we add them here.
> +     `(("python-2" ,python-2)
> +       ("python-3" ,python-3)))

I think we should take another approach. Doing it this way makes the
python-odfpy and python2-odfpy built outputs refer to both Python
versions:

$ guix gc --references $(./pre-inst-env guix build python2-odfpy)
/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3
/gnu/store/s0ckr1yhrzgfisxpsfz5b8mybjmvqkf1-python2-odfpy-1.3.3
/gnu/store/vcx1n5nj4gr52xx5m6gvi7zrwngy06s3-python-2.7.11
/gnu/store/ykzwykkvr2c80rw4l1qh3mvfdkl7jibi-bash-4.3.42

This looks like the file to patch:
https://github.com/eea/odfpy/blob/master/tests/runtests