Re: [PATCH] gnu: Add python-odfpy.

[Leo Famulari <leo@famulari.name>]

On Wed, Aug 17, 2016 at 05:53:31PM +0100, Marius Bakke wrote:
> Subject: [PATCH] gnu: Add python-odfpy.
> 
> * gnu/packages/python.scm (python-odfpy, python2-odfpy): New variables.

Thanks for the patch!

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _ (zero? (system* "make" "-C" "tests")))))))
> +    (native-inputs
> +     ;; The test runner wants to check both python versions at once.
> +     ;; To avoid patching it, we add them here.
> +     `(("python-2" ,python-2)
> +       ("python-3" ,python-3)))

I think we should take another approach. Doing it this way makes the
python-odfpy and python2-odfpy built outputs refer to both Python
versions:

$ guix gc --references $(./pre-inst-env guix build python2-odfpy)
/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3
/gnu/store/s0ckr1yhrzgfisxpsfz5b8mybjmvqkf1-python2-odfpy-1.3.3
/gnu/store/vcx1n5nj4gr52xx5m6gvi7zrwngy06s3-python-2.7.11
/gnu/store/ykzwykkvr2c80rw4l1qh3mvfdkl7jibi-bash-4.3.42

This looks like the file to patch:
https://github.com/eea/odfpy/blob/master/tests/runtests