From: Leo Famulari <leo@famulari.name>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
Date: Fri, 19 Aug 2016 17:46:38 -0400 [thread overview]
Message-ID: <20160819214638.em6gtk7bv3ea4l3n@jasmine> (raw)
In-Reply-To: <87lgzvqlio.fsf@gmail.com>
On Wed, Aug 17, 2016 at 09:48:47PM +0300, Alex Kost wrote:
> Leo Famulari (2016-08-17 00:41 +0300) wrote:
>
> > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
> >> gnu: Add python-lirc, python2-lirc.
> >>
> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
> >
> > Thanks, applied as 231313f76!
>
> Ahem, you both are fast: I was commenting on the first patch, and
> suddenly found that the third revision is already pushed :-)
> Anyway, some comments:
I pushed fixes for the indentation and the misleading file-name.
> > + (description "@code{lirc} is a Python module which provides LIRC bindings.")
>
> I don't think the description should begin with "@code{lirc}" as it is
> not LIRC itself but a python library for LIRC.
Not knowing what to replace this with, I left it alone.
prev parent reply other threads:[~2016-08-19 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 21:28 [PATCH v3] gnu: Add python-lirc, python2-lirc Danny Milosavljevic
2016-08-16 21:41 ` Leo Famulari
2016-08-17 18:48 ` Alex Kost
2016-08-19 21:46 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819214638.em6gtk7bv3ea4l3n@jasmine \
--to=leo@famulari.name \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.