From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Lepiller <julien@lepiller.eu>
Subject: Re: [PATCH] openssh service
Date: Fri, 19 Aug 2016 16:03:35 +0200
Message-ID: <20160819160335.3ed70813@polymos>
References: <20160805141840.447dd381@polymos> <87oa57jpix.fsf@igalia.com>
	<20160805162049.491063d9@polymos>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1bakOf-0005d4-6E
	for guix-devel@gnu.org; Fri, 19 Aug 2016 10:03:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1bakOa-0004Ou-Un
	for guix-devel@gnu.org; Fri, 19 Aug 2016 10:03:44 -0400
Received: from dau94-h03-89-91-205-84.dsl.sta.abo.bbox.fr
	([89.91.205.84]:46478 helo=lepiller.eu)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1bakOa-0004O2-Hd
	for guix-devel@gnu.org; Fri, 19 Aug 2016 10:03:40 -0400
Received: from localhost (localhost [127.0.0.1])
	by lepiller.eu (Postfix) with ESMTP id E76F2408CA
	for <guix-devel@gnu.org>; Fri, 19 Aug 2016 16:03:36 +0200 (CEST)
Received: from lepiller.eu ([127.0.0.1])
	by localhost (skaro.lepiller.eu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LXCvK5hMsiMi for <guix-devel@gnu.org>;
	Fri, 19 Aug 2016 16:03:25 +0200 (CEST)
Received: from polymos (bbox.lan [192.168.1.254])
	by lepiller.eu (Postfix) with ESMTPSA id B4334410A6
	for <guix-devel@gnu.org>; Fri, 19 Aug 2016 16:03:24 +0200 (CEST)
In-Reply-To: <20160805162049.491063d9@polymos>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

On Fri, 5 Aug 2016 16:20:49 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> On Fri, 05 Aug 2016 15:47:50 +0200
> Andy Wingo <wingo@igalia.com> wrote:
> 
> > On Fri 05 Aug 2016 14:18, Julien Lepiller <julien@lepiller.eu>
> > writes: 
> > > here is a patch that adds a service definition for openssh.    
> > 
> > Very nice!
> >   
> > > +      (let ((pid (primitive-fork)))
> > > +        (case pid
> > > +          ((0)
> > > +           (execl (string-append #$openssh "/bin/ssh-keygen")
> > > +                  "ssh-keygen" "-A")
> > > +          (else
> > > +           (zero? (cdr (waitpid pid)))))))    
> > 
> > I guess you could system* this one instead; would be easier I think.
> > Dunno.  
> 
> I modified my patch, so you can choose whichever feels better.
> 
> > 
> > Other than that looks all good to me.  Would need an addition to the
> > manual eventually though.  
> 
> > 
> > Andy  
> 

Hi,

It's been a bit of time since I posted the patch, but didn't hear any
news about it. What's wrong with it? Is it that I misunderstood the
"Would need an addition to the manual eventually though"? Does that
mean I need to add an entry to the manual myself (if so, could you
tell me what file to edit?)