From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH v2 2/6] gnu: fpga: Add abc. Date: Thu, 18 Aug 2016 15:51:47 +0200 Message-ID: <20160818155147.3f98f633@scratchpost.org> References: <20160816180653.22524-1-dannym@scratchpost.org> <20160816180653.22524-3-dannym@scratchpost.org> <87twei74u7.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baNje-0001SE-OH for guix-devel@gnu.org; Thu, 18 Aug 2016 09:51:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baNja-00049T-23 for guix-devel@gnu.org; Thu, 18 Aug 2016 09:51:53 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:33861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baNjZ-00049O-SH for guix-devel@gnu.org; Thu, 18 Aug 2016 09:51:50 -0400 In-Reply-To: <87twei74u7.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org > What does this mean for us? Should we offer two packages? Or is this > only needed for developer users of this package? I=E2=80=99m inclined to= just > drop this comment. What do you think? I only install the binary and no library so it doesn't really matter. We ca= n drop the comment - if we should need the library later we can find the co= mment in the mailing list archives. > We prefer to have the full commit here and abbreviate it in the version > string. We usually also add a =E2=80=9Crevision=E2=80=9D or =E2=80=9Cgui= x-revision=E2=80=9D variable > (starting at 0 or 1). That=E2=80=99s easier to update than having to mod= ify the > version string directly each time the commit changes. Yeah, back then I didn't take care of it. Sorry. Please add. > =E2=80=9C'check=E2=80=9D (with the leading quote indicating that it is a = Scheme symbol) > is a phase name in Guix. It would be less confusing if the comment just > said >=20 > =E2=80=9Cno check target=E2=80=9D Yeah. > =E2=80=9Cinstall-file=E2=80=9D does not need to be given a target file na= me, just a > target directory. Ok! > > + (home-page "http://people.eecs.berkeley.edu/~alanmi/abc/") > > + (synopsis "Sequential Logic Synthesis and Formal Verification") =20 >=20 > Let=E2=80=99s put this in lower case (except for the first word). >=20 > Thanks again! Would you like me to take care of the changes or would > you prefer to send an updated patch? Yes please do. Note that Leo also proposed to write (license (license:non-copyleft "https://fedoraproject.org/wiki/Licensin= g:MIT#Modern_Variants"))))) as license.