From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it. Date: Tue, 16 Aug 2016 21:39:52 +0200 Message-ID: <20160816213952.0f96a96f@scratchpost.org> References: <20160816181310.23954-1-dannym@scratchpost.org> <87vaz05xk9.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZkDU-0005ES-Dq for guix-devel@gnu.org; Tue, 16 Aug 2016 15:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZkDQ-0002nX-9h for guix-devel@gnu.org; Tue, 16 Aug 2016 15:40:03 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZkDQ-0002nR-2g for guix-devel@gnu.org; Tue, 16 Aug 2016 15:40:00 -0400 In-Reply-To: <87vaz05xk9.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org Hi, > Can you be more specific why it is removed? I don't understand the harm > it does or doesn't do when it's included. > Would this not be bad for packages which require setuptools? Python 3.4 integrated setuptools into the main distribution. It doesn't require an external python-setuptools. I don't understand why Guix even still has a "python-setuptools" package. (python2-setuptools is OK - but the other one: why?) New packages are usually Python 3 compatible. Also, the python-build-system defaults to Python 3. That's why I assume that the package S-Expression printed is for Python 3 (and so do many other Guix parts). There, it doesn't make sense to include setuptools anymore. Also, it's better if the package expression doesn't include python-setuptools by default because a lazy packager (i.e. me) will just copy & paste it and call it a day. Then the new package depends on python-setuptools even though it doesn't need it at all. I'm not sure what to do about the Python 2 package expression. I think this function only can return one expression. If possible, I'd like it to automatically print the Python 2 package expression, for example (define-public python2-lockfile (let ((base (package-with-python2 (strip-python2-variant python-lockfile)))) (package (inherit base) (native-inputs `(("python2-setuptools" ,python2-setuptools) ,@(package-native-inputs base)))))) , as well.