From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH v2] gnu: python: Add python-lirc. Date: Tue, 16 Aug 2016 16:56:08 -0400 Message-ID: <20160816205608.GB25753@jasmine> References: <20160816202115.22554-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZlPc-000523-Ua for guix-devel@gnu.org; Tue, 16 Aug 2016 16:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZlPT-0002qU-8H for guix-devel@gnu.org; Tue, 16 Aug 2016 16:56:39 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZlPO-0002nE-NP for guix-devel@gnu.org; Tue, 16 Aug 2016 16:56:31 -0400 Content-Disposition: inline In-Reply-To: <20160816202115.22554-1-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org On Tue, Aug 16, 2016 at 10:21:15PM +0200, Danny Milosavljevic wrote: > gnu: python: Add python-lirc. > > * gnu/packages/python.scm (python-lirc, python2-lirc): New variables. Can you put it in the lirc module? > +(define-public python-lirc > + (let ((commit "4091fe918f3eed2513dad008828565cace408d2f")) > + (package > + (name "python-lirc") > + (version (string-append "1.2.1-" (string-take commit 7))) Please add a package revision counter as shown in the manual section 7.6.3 Version Numbers. https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers LGTM with these changes. By the way, I looked at the Git log and so I know that you have been working on this software upstream. That's cool :) But, in general, when sending patches, please give an explanation of why we should build from a Git commit instead of the latest release tag. Because we are always going to ask and it slows down the review process.