From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pjotr Prins Subject: Re: [PATCH] gnu: Add clojure. Date: Tue, 16 Aug 2016 20:56:48 +0200 Message-ID: <20160816185648.GA22829@thebird.nl> References: <87r3b7gc4d.fsf@gmail.com> <8737ndiln5.fsf@elephly.net> <87h9bs4amm.fsf@gmail.com> <87twfe7n6t.fsf@elephly.net> <87h9bc36wg.fsf@gmail.com> <87y44okw3r.fsf@elephly.net> <87bn1j60i5.fsf@gmail.com> <87inv21aw5.fsf@elephly.net> <87bn0sc072.fsf@gmail.com> <877fbg1rk2.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZjY4-0000bO-1T for guix-devel@gnu.org; Tue, 16 Aug 2016 14:57:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZjXz-00023E-Sk for guix-devel@gnu.org; Tue, 16 Aug 2016 14:57:15 -0400 Received: from mail.thebird.nl ([95.154.246.10]:43873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZjXz-000239-NC for guix-devel@gnu.org; Tue, 16 Aug 2016 14:57:11 -0400 Content-Disposition: inline In-Reply-To: <877fbg1rk2.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org On Tue, Aug 16, 2016 at 08:45:17PM +0200, Ricardo Wurmus wrote: >=20 > Alex Vong writes: >=20 > > Thanks for the review too. The changes looks good to me, excepts that= it > > seems 'find-files' will find all files with name matching the regex > > recursively, but `scandir' will only list the files on the 1st > > level. >=20 > Ah, I didn=E2=80=99t notice that this is what you were trying to do the= re. > Using =E2=80=9Cscandir=E2=80=9D is fine then. >=20 > > Also, I realize there is a typo in my original patch. It should be > > 'under' instead of 'under under' in the comment. >=20 > Excellent! Pushed to master as > 8293b116e64f543848f4845723208973aeb993f9. Thank you for your > perseverance! Awesome. Another compiler gone in! --=20