Re: [PATCH 4/5] gnu: arduino: Add arduino-libraries.

[Eric Bavier <ericbavier@openmailbox.org>]

On Tue, 16 Aug 2016 20:36:31 +0200
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> * gnu/packages/arduino.scm (arduino-libraries): New variable.
> ---
>  gnu/packages/arduino.scm | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

> diff --git a/gnu/packages/arduino.scm b/gnu/packages/arduino.scm
> index ae69c04..675df80 100644
> --- a/gnu/packages/arduino.scm
> +++ b/gnu/packages/arduino.scm
> @@ -91,3 +91,18 @@
>      (description "arduino-hardware contains Arduino Hardware Spec Files (boards.txt etc).")
>      ;; GPL covers the main body ("app", "core"). LGPL covers the remainder.
>      (license license:lgpl2.1+))) ; FIXME check
> +
> +(define-public arduino-libraries
> +  (package (inherit arduino-hardware)

This seems like a false inheritence to me.  Do arduino-hardware and
arduino-libraries really need to be separate packages?  This are build
from the same source.  I don't know the package at all, but it seems
like you might be able to do away with the dependencies setup and the
arduino-installer procedure if the two are built together.  WDYT?

> +    (name "arduino-libraries")
> +    (inputs `(("arduino-hardware" ,arduino-hardware)))
> +    (arguments
> +      (substitute-keyword-arguments
> +        (package-arguments arduino-hardware)
> +        ((#:phases phases)
> +            `(modify-phases ,phases
> +              (replace 'chdir
> +                (lambda _
> +                  (chdir "libraries")))
> +              (replace 'install ,(arduino-installer "libraries"))))))
> +    (license license:lgpl2.1))) ; FIXME check apache license etc
                                     ^
This of course needs to be resolved before pushing.

`~Eric