From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-reportlab.
Date: Mon, 15 Aug 2016 20:36:31 -0400
Message-ID: <20160816003631.GB16946@jasmine>
References: <87inv2gqlt.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
	<87bn0ugmhv.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSN5-0006bh-1n
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:36:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSMz-0000cu-A8
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:36:46 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSMy-0000cO-3P
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:36:41 -0400
Content-Disposition: inline
In-Reply-To: <87bn0ugmhv.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
> 
> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
> > From: Marius Bakke <mbakke@fastmail.com>
> > Date: Sun, 14 Aug 2016 16:47:33 +0100
> > Subject: [PATCH] gnu: Add python-reportlab.
> >
> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
> >   variables.
> > ---
> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> 
> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?

Looks good. I think pdf.scm is better. Can you send another patch?

> +     ;; Prevent creation of the egg. Without this flag, various artifacts
> +     ;; from the build inputs end up in the final python3 output. It also
> +     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
> +     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))

Feel free to add something to that discussion. We are starting a new
"core-updates" cycle, so it's a good time to begin implementing changes
to core components such as build systems.