From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add dlib.
Date: Sun, 14 Aug 2016 13:25:44 -0400 [thread overview]
Message-ID: <20160814172544.GA28736@jasmine> (raw)
In-Reply-To: <8737m837zk.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
On Sat, Aug 13, 2016 at 06:15:59PM +0100, Marius Bakke wrote:
> * gnu/packages/machine-learning.scm (dlib): New variable.
Thanks!
> + (version "19.0")
The released 19.1 yesterday. Will you send an updated patch using the
latest version?
> + (arguments
> + `(#:phases
> + (let ((test-dir (string-append "../dlib-" ,version "/dlib/test/build")))
> + (modify-phases %standard-phases
> + (add-before 'check 'build-test-suite
> + ;; No test target, so we build and run the unit tests here.
> + (lambda _
> + (mkdir-p test-dir)
> + (chdir test-dir)
> + (zero? (system* "cmake" ".."))
> + (zero? (system* "cmake" "--build" "." "--config" "Release"))))
> + (replace 'check
> + (lambda _ (zero? (system* "./dtest" "--runall"))))
I think we should combine these two phases, and use
with-directory-excursion (defined in guix build utils) instead of
chdir-ing back and forth.
> + (add-after 'check 'ascend-to-build-directory
> + (lambda _ (chdir "../../../../build") #t))))))
Then, this phase can be removed.
What do you think?
next prev parent reply other threads:[~2016-08-14 17:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 17:15 [PATCH] gnu: Add dlib Marius Bakke
2016-08-14 17:25 ` Leo Famulari [this message]
2016-08-14 19:52 ` Marius Bakke
2016-08-15 7:43 ` Alex Kost
2016-08-15 11:51 ` Marius Bakke
2016-08-15 20:15 ` Leo Famulari
2016-08-15 20:29 ` Marius Bakke
2016-08-15 22:28 ` Leo Famulari
2016-08-16 0:15 ` Ben Woodcroft
2016-08-16 10:45 ` Marius Bakke
2016-08-16 20:47 ` Leo Famulari
2016-08-16 23:31 ` Ben Woodcroft
2016-08-16 23:45 ` Leo Famulari
2016-08-17 3:24 ` Ben Woodcroft
2016-08-17 5:01 ` Ben Woodcroft
2016-08-17 14:48 ` Marius Bakke
2016-08-18 20:23 ` Leo Famulari
2016-08-19 10:52 ` Marius Bakke
2016-08-21 20:17 ` Leo Famulari
2016-08-22 2:30 ` Ben Woodcroft
2016-08-22 12:01 ` Marius Bakke
2016-08-23 18:33 ` Marius Bakke
2016-08-24 10:26 ` Marius Bakke
2016-08-24 17:26 ` Leo Famulari
2016-08-24 19:08 ` Marius Bakke
2016-08-24 22:51 ` Ben Woodcroft
2016-08-30 14:43 ` Marius Bakke
2016-08-31 19:09 ` Leo Famulari
2016-09-09 12:15 ` Marius Bakke
2016-09-10 12:32 ` Marius Bakke
2016-09-10 18:16 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-08-18 20:18 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160814172544.GA28736@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.