From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add sg3_utils. Date: Sun, 14 Aug 2016 12:46:32 -0400 Message-ID: <20160814164632.GA1754@jasmine> References: <87fuq9xawl.fsf@gmail.com> <87bn0xxafb.fsf@gmail.com> <20160814012743.GB17421@jasmine> <871t1skp8l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYyYh-00067v-7d for guix-devel@gnu.org; Sun, 14 Aug 2016 12:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYyYd-0008MC-1c for guix-devel@gnu.org; Sun, 14 Aug 2016 12:46:46 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYyYb-0008Kf-OK for guix-devel@gnu.org; Sun, 14 Aug 2016 12:46:42 -0400 Content-Disposition: inline In-Reply-To: <871t1skp8l.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel@gnu.org --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 13, 2016 at 08:23:38PM -0700, Chris Marusich wrote: > sg3_utils and its library can be used with any SCSI device, which > includes many devices which are not hard disks, such as CD-ROMs and > media changers (i.e., jukeboxes), so I don't think it makes sense to put > it into a file whose scope is limited to disks. Ah, I can't wait for jukebox.scm ;) > >> + #:use-module ((guix licenses) > >> + #:select (gpl2+ bsd-3)) > > > > Do we need to use #:select here? How about using a license prefix? What > > are the pros and cons? I'll leave this as is. > > We like to use underscores instead of hyphens in package names: > > > > https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#= Package-Naming >=20 > Thank you for pointing this out. I've updated it (see attached patch). Thanks for understanding my mistake; I got it backwards in the sentence you replied to :p >=20 > > I think that dd, and all the sg_* commands, should be wrapped in texinfo > > markup, like this: > > > > @code{dd} >=20 > Done! Thanks for the tip. Thanks! Pushed as 5cf30103f7. --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXsKBkAAoJECZG+jC6yn8IfqcQAIg8g+HKi0J0UMOZSwCOGCne y18LEBys3K0ZHnzhDSxCjtXUoQ1wiFFti2OWWm8bzXHAWi7xL8w8RFn+d9fWzDsN 7yZf3BiNgSYUkcKDnUnToY/Yoez0BqUBkFiHIIMQFwn5AOT5OWw0uYtNk0r1Iqvu MPcIwefJqi88jqLcag2g9ctg9ez5a6Y8xLI7u8ap0AoOhokUxfILszavEn0qimiV 4s1muNmKt8KKWfmBmv38QUh7rGDcu6sUQ7tfJ5NluZUS3t/VTkKt18Ap8PGkdUuX 5WUuwvtE+/uzp8LMrU+x4UByj6k1i6mZUEiYx+OcDeGEH1VhWm8HgJC3fsztrKII vjOXdoIpcazfJEJcTeimqLKJH/YRAdiJfnaQlZU/JYnk46S9t+2TI/jSydPf6t6Z AeSz1HAu7ZOWun543Xwzcl6jZC6jdmQLaFGbhoe5Hfpe7eod6YGW5PEZPKqbfqOc OPej6qzdbqdCsWccpYbGoxYZCVok/hX/hnkpp4POWFkQ7Nv/SigiFYRD1ndrwEOj Ekr94dssnEWGazzD1ZLnU/1L9pPzyLuTS16U2ezcENDMXilX5/f/sc6lDdQDe3qa Z2p3mEmrZ3b6MAqxaLewriFv6u2YVHimISVWzuTOre4zL4Hap+A3ybBFpeVoOQPw YiBzN+Ivg3tW4UA2YJW2 =owyl -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--