From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 10/13] gnu: kde-frameworks: Add kpackage.
Date: Sat, 13 Aug 2016 21:54:33 -0400 [thread overview]
Message-ID: <20160814015433.GD17421@jasmine> (raw)
In-Reply-To: <20160813121931.20071-11-david@craven.ch>
On Sat, Aug 13, 2016 at 02:19:28PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (kpackage): New variable.
> + (arguments
> + `(#:tests? #f ; FIXME: 1/4 tests fail.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-test
> + (lambda* _
> + (substitute* "autotests/packagestructuretest.cpp"
> + (("//qDebug\\(\\) << path;") "qDebug() << path;"))))
So, this is "un-commenting" the line, right? Will you add a comment in
the package definition explaining why we do it?
next prev parent reply other threads:[~2016-08-14 1:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 12:19 [PATCH 00/13] KDE Frameworks Tier 2 packages and phonon/gpgmepp David Craven
2016-08-13 12:19 ` [PATCH 01/13] gnu: kde-frameworks: Add phonon David Craven
2016-08-13 12:19 ` [PATCH 02/13] gnu: kde-frameworks: Add kauth David Craven
2016-08-13 12:19 ` [PATCH 03/13] gnu: kde-frameworks: Add kcompletion David Craven
2016-08-22 6:09 ` Mark H Weaver
2016-08-22 11:09 ` David Craven
2016-08-13 12:19 ` [PATCH 04/13] gnu: kde-frameworks: Add kcrash David Craven
2016-08-13 12:19 ` [PATCH 05/13] gnu: kde-frameworks: Add kdoctools David Craven
2016-08-13 12:19 ` [PATCH 06/13] gnu: kde-frameworks: Add kfilemetadata David Craven
2016-08-13 12:19 ` [PATCH 07/13] gnu: kde-frameworks: Add kimageformats David Craven
2016-08-13 12:19 ` [PATCH 08/13] gnu: kde-frameworks: Add kjobwidgets David Craven
2016-08-13 12:19 ` [PATCH 09/13] gnu: kde-frameworks: Add knotifications David Craven
2016-08-13 12:19 ` [PATCH 10/13] gnu: kde-frameworks: Add kpackage David Craven
2016-08-14 1:54 ` Leo Famulari [this message]
2016-08-14 18:16 ` David Craven
2016-08-13 12:19 ` [PATCH 11/13] gnu: kde-frameworks: Add kpty David Craven
2016-08-14 1:58 ` Leo Famulari
2016-08-13 12:19 ` [PATCH 12/13] gnu: kde-frameworks: Add kunitconversion David Craven
2016-08-13 12:19 ` [PATCH 13/13] gnu: kde-frameworks: Add gpgmepp David Craven
2016-08-17 16:02 ` [PATCH 00/13] KDE Frameworks Tier 2 packages and phonon/gpgmepp Andreas Enge
2016-08-17 16:15 ` David Craven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160814015433.GD17421@jasmine \
--to=leo@famulari.name \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.