From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add sg3_utils. Date: Sat, 13 Aug 2016 21:27:43 -0400 Message-ID: <20160814012743.GB17421@jasmine> References: <87fuq9xawl.fsf@gmail.com> <87bn0xxafb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYkDX-00068M-Ck for guix-devel@gnu.org; Sat, 13 Aug 2016 21:28:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYkDR-0005t5-Ci for guix-devel@gnu.org; Sat, 13 Aug 2016 21:27:58 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYkDQ-0005st-5l for guix-devel@gnu.org; Sat, 13 Aug 2016 21:27:53 -0400 Content-Disposition: inline In-Reply-To: <87bn0xxafb.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel@gnu.org --TakKZr9L6Hm6aLOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 13, 2016 at 02:52:56AM -0700, Chris Marusich wrote: > Chris Marusich writes: > Subject: [PATCH] gnu: Add sg3_utils. >=20 > * gnu/local.mk: Include gnu/packages/scsi.scm. > * gnu/packages/scsi.scm: Add new file. > * gnu/packages/scsi.scm (sg3_utils): New variable. Thanks for this patch! How about putting it in disk.scm? I have no strong preference either way. I don't like moving things around too much once they have been created, however :) > + #:use-module ((guix licenses) > + #:select (gpl2+ bsd-3)) Do we need to use #:select here? How about using a license prefix? What are the pros and cons? > +(define-public sg3_utils > + (package > + (name "sg3_utils") We like to use underscores instead of hyphens in package names: https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#Pack= age-Naming > + (description > + "sg3_utils is a collection of utilities for devices that use the Sm= all > +Computer System Interface (SCSI) command set. It includes utilities to = read > +data from, write data to, control, modify, and query the state of SCSI > +devices. For example, this package provides command-line tools to copy = data > +based on \"dd\" syntax and semantics (called sg_dd, sgp_dd and sgm_dd), = check > +INQUIRY data and VPD pages (sg_inq), check mode and log pages (sginfo, > +sg_modes and sg_logs), spin up and down disks (sg_start), do self > +tests (sg_senddiag), parse sense data, and perform various other functio= ns. > +In addition, this package includes a library, called libsgutils, which c= an be > +used in C and C++ programs to interact with SCSI devices.") I think that dd, and all the sg_* commands, should be wrapped in texinfo markup, like this: @code{dd} Can you send an updated patch? --TakKZr9L6Hm6aLOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXr8kPAAoJECZG+jC6yn8ImlwQAJqmOvhMe6Q44ndjZcJQuzRg chhwDkcAwNfTNxCnVO4ZAgAxtkCOjOTxXbIU9blZqjX0Vl3zLxUco4VFz3q/my0i tuBm8NSr/cAfpfLQfmr6+qrzkchjnOIcoJs6jwq3r19Zp8o5hQZECeBk9u+PEtjg urlUENU2V4RfH2MzqifdP1CH1Dj7w7vsFQB6SkniumD7sdx2BVYCkNdVjNEmFBse BWTj7pqKnDfiuHDv2gu3aiS9arqqF0mYrXcIn+unAHn4kMrzSMODEgPPbNvMtLvJ MKhK5lHqarnTcH78WDJASFEcVDGxylSSO7kbRq69xXPZYxib0wc9idbo4SUW2VwO evygpkSW1mzGdVMXrkZEA9AuCItPb/ti53SZlaeBlENJ3JteMZvgnx+ng2SugTeP 5EcDom/HwgVN0Th35j5dHVgyira5F4K19gvIbT3T1pAuUI90qUFT6VmbC8x+n+bw pgneZoqw4wauJqp1Mt3p+qi5F53wpnJvZCJNXI451ysdk6Q3vgQx9JsIhY0lYQ46 FkiZ/1YnpmFTgKuT/o/T+iD5b3CPU/vcUZLjOZikACTebQSgxkEtGV2w/DPneStA 1ds/QWBhUiDsPIEB01w5dzXdQm7rd1CG6evHGGkKA3ojdzSwdN8Dlu6fvs3FGoyT Ldf1yIiDhUCtRQSUBART =cNsr -----END PGP SIGNATURE----- --TakKZr9L6Hm6aLOc--