From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-pypump
Date: Sat, 13 Aug 2016 19:07:14 -0400
Message-ID: <20160813230714.GA22289@jasmine>
References: <20160812183129.0f76b28a@openmailbox.org>
	<20160813125700.GA12089@jasmine>
	<20160813123242.6162b166@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYi1c-00023k-Vp
	for guix-devel@gnu.org; Sat, 13 Aug 2016 19:07:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYi1X-0008HX-Rd
	for guix-devel@gnu.org; Sat, 13 Aug 2016 19:07:32 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYi1V-0008Fj-Cq
	for guix-devel@gnu.org; Sat, 13 Aug 2016 19:07:27 -0400
Content-Disposition: inline
In-Reply-To: <20160813123242.6162b166@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Dylan Jeffers <sapientech@openmailbox.org>
Cc: guix-devel@gnu.org

On Sat, Aug 13, 2016 at 12:32:42PM -0700, Dylan Jeffers wrote:
> Thanks for getting back. Here is the series!

Cool, you showed me something new. I didn't know you could put the whole
series in a single attachment, apply it with `git am`, and have the
patch ordering handled automatically. Very nice :)

> Subject: [PATCH 1/2] gnu: Add python-requests-oauthlib
> 
> * gnu/packages/python.scm (python-requests-oauthlib,
> * python2-requests-oauthlib): New variables.

Somewhere in the re-creation of the patch series, this line was
forgotten:

+  #:use-module (gnu packages openstack)

I put it back in on my local branch.

> * gnu/packages/python.scm (python-pypump, python2-pypump): New
> * variables.

How about putting this in gnu/packages/pumpio.scm? Seems appropriate to
me :)

> +(define-public python-pypump
> +  (package
> +    (name "python-pypump")
> +    (version "0.6")

The latest upstream version 0.7. Is there a reason not to use the latest
version in this case?

https://pypi.python.org/pypi/PyPump/